Skip to content

Commit

Permalink
Disable py launcher by default in the Windows installer
Browse files Browse the repository at this point in the history
Summary:
we deploy an official upstream py launcher separately.
it's deployed under `C:\Windows`, so it's important that it has valid signatures (which our build does not).
to avoid the managed cpython installation from "hijacking" the launcher, this makes the launcher feature disabled by default in the managed installer.

Reviewed By: zsol

Differential Revision: D55898720

fbshipit-source-id: 2d5eb2508227e85ef1043d581c04faa31f86f245
  • Loading branch information
itamaro authored and facebook-github-bot committed Apr 18, 2024
1 parent 34709a9 commit 5571ad6
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions Tools/msi/bundle/bundle.wxs
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,7 @@
<Variable Name="DefaultCustomTargetDir" Value="" bal:Overridable="yes" />

<Variable Name="InstallAllUsersState" Value="enabled" bal:Overridable="yes" />
<?if "$(var.PyTestExt)"="" ?>
<Variable Name="InstallLauncherAllUsersState" Value="enabled" bal:Overridable="yes" />
<?else ?>
<Variable Name="InstallLauncherAllUsersState" Value="disable" bal:Overridable="yes" />
<?endif ?>
<Variable Name="CustomInstallLauncherAllUsersState" Value="[InstallLauncherAllUsersState]" />
<Variable Name="TargetDirState" Value="enabled" />
<Variable Name="CustomBrowseButtonState" Value="enabled" />
Expand All @@ -76,11 +72,7 @@
<Variable Name="Include_tcltk" Value="0" bal:Overridable="yes" />
<Variable Name="Include_pip" Value="0" bal:Overridable="yes" />
<Variable Name="Include_launcher" Value="-1" bal:Overridable="yes" />
<?if "$(var.PyTestExt)"="" ?>
<Variable Name="Include_launcherState" Value="enabled" bal:Overridable="yes" />
<?else ?>
<Variable Name="Include_launcherState" Value="disable" />
<?endif ?>
<Variable Name="Include_symbols" Value="0" bal:Overridable="yes" />
<Variable Name="Include_debug" Value="0" bal:Overridable="yes" />

Expand Down

0 comments on commit 5571ad6

Please sign in to comment.