Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seg fault indexing float chkdict with int key #34

Closed
DinoV opened this issue Jul 6, 2021 · 1 comment
Closed

Seg fault indexing float chkdict with int key #34

DinoV opened this issue Jul 6, 2021 · 1 comment
Assignees
@DinoV
Labels
sp-correctness static python correctness staticpython static python issues

Comments

@DinoV
Copy link
Contributor

DinoV commented Jul 6, 2021

This should report an error, not crash:

from __static__ import CheckedDict

def main():
    d = CheckedDict[float, str]({2.0: "hello", 2.3: "foobar"})
    print(d[2])
    return

main()
@DinoV DinoV added staticpython static python issues sp-correctness static python correctness labels Jul 6, 2021
@DinoV DinoV self-assigned this Dec 20, 2021
facebook-github-bot pushed a commit that referenced this issue Dec 22, 2021
@DinoV @facebook-github-bot
Add test case for Github issue #34
295a0a3 
Summary: We're no longer crashing, this now adds a test case that we should be treating `float` as dynamic here.

Reviewed By: wmeehan

Differential Revision: D33243366

fbshipit-source-id: e4b9c56
@carljm
Copy link
Contributor

carljm commented Feb 6, 2024

This should be fixed now.

@carljm carljm closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DinoV DinoV

Labels
sp-correctness static python correctness staticpython static python issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carljm @DinoV