-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created a Dockerfile for Fedora 32 #3
Created a Dockerfile for Fedora 32 #3
Conversation
Created a Dockerfile using Fedora32 to aid development with cython
Hi @zitterbewegung! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
1 similar comment
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thanks for the PR! Can you give us more information about the use case for this? (i.e. Is the intent to drop the user into a container with the repo for development?) |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Why Fedora? I think it would be much better if we use same base image with official Python docker images, which are buster, alpine or Windows server core. Also, no need to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's some feedback to tune this up to be simpler and more performant in the repo. 😉
Fedora is the platform used for Facebook projects these days. Also note that Fedora is the ultimate upstream for the platform used for |
Fedora was in the Readme as the only distribution that cinder was verified to work on. I will remove the git clone change. |
Yes, it would drop someone in the repo for the environment easily for development since not everyone us running the specific version of Fedora. |
RUN dnf --assumeyes --refresh group install "Development Tools" "Development Libraries" | ||
RUN dnf clean all | ||
ADD . /cinder | ||
RUN /cinder/oss-build-and-test.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this line? Assuming the intent of the Dockerfile is to give users a development container that has all the dependencies necessary to build Cinder, that's all it should do.
Sorry I'm a bit late to the party here. We actually already have a Docker spec file in I appreciate the above probably wasn't obvious, so I've updated the Although I'm closing this PR, I hope you get your intended end result of a more ergonomic dev setup for Cinder. |
Created a Dockerfile using Fedora32 to aid development with cython compatibility and general development ergonomics