Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm start gives "Module build failed: Error: Failed to load plugin import: Cannot find module 'eslint-plugin-import'" #2779

Closed
CharlesIrvineKC opened this issue Jul 13, 2017 · 17 comments

Comments

@CharlesIrvineKC
Copy link

Is this a bug report?

Yes, seems like it to me.

Can you also reproduce the problem with npm 4.x?

I haven't tried yet. I think that would be a wild goose chase. This problem just started today out of the blue. My hunch is that is an environment problem of some sort.

Which terms did you search for in User Guide?

I did a google search instead. Found no help.

Environment

  1. node -v: v8.1.2
  2. npm -v: 5.2.0
  3. yarn --version (if you use Yarn): don't use
  4. npm ls react-scripts (if you haven’t ejected): react-scripts@1.0.10

Then, specify:

  1. Operating system: macOS 10.12.5
  2. Browser and version (if relevant): Chrome Version 59.0.3071.115 (Official Build) (64-bit)

Steps to Reproduce

(Write your steps here:)

Invoke:

  1. create-react-app my-app (no issues here)
  2. cd my-app
  3. npm start

After step #3 the console window shows:

Failed to compile.

./src/index.js
Module build failed: Error: Failed to load plugin import: Cannot find module 'eslint-plugin-import'
Referenced from: 
    at Array.forEach (native)
    at Array.reduceRight (native)

Expected Behavior

(Write what you thought would happen.)

Actual Behavior

(Write what happened. Please add screenshots!)

Reproducible Demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

@deehuey
Copy link

deehuey commented Jul 13, 2017

npm install eslint-plugin-import is a temporary fix while you await a proper fix!

@tenzan
Copy link

tenzan commented Jul 13, 2017

I had same issue.
Installing manually following modules was a fix for me:

eslint-plugin-import
eslint-plugin-react
eslint-plugin-flowtype
eslint-plugin-jsx-a11y

@rdmurphy
Copy link

rdmurphy commented Jul 13, 2017

Can confirm I'm seeing this too with a fresh create-react-app setup. Doesn't seem to be a problem when I use yarn, however. I'm at yarn@0.27.5, node@v6.11.0 and npm@5.2.0.

@Timer
Copy link
Contributor

Timer commented Jul 13, 2017

The following is working fine:

$ npx create-react-app test-eslint
$ cd test-eslint/
$ yarn start
$ npm -v
5.2.0
$ node -v
v8.1.4

This means it's an NPM bug or an environment bug.
Either way, you should try NPM 4 like suggested as NPM 5 is very buggy.

If you can tell us how or why your environment is unique, we may be able to help. But this is not a bug on our end.

@tjkSec
Copy link

tjkSec commented Jul 13, 2017

Switching back to npm@4.6.1 solved the issue for me.

@Timer
Copy link
Contributor

Timer commented Jul 13, 2017

Thanks for confirming @tjkSec; closing this as author failed to follow the issue template.

For anyone experiencing this issue; please use NPM 4.x (npm install -g npm@4).

@Timer Timer closed this as completed Jul 13, 2017
@nathan-charrois
Copy link

Users on reddit reporting the same issue. Agree it's a problem with NPM.

@Timer
Copy link
Contributor

Timer commented Jul 13, 2017

I've commented on reddit, @NathanCH. Thanks for the heads up.

@gaearon
Copy link
Contributor

gaearon commented Jul 13, 2017

Please file bugs with npm too so they can fix.

@kachkaev
Copy link

kachkaev commented Jul 13, 2017

@tenzan thanks for the full list of plugins that npm 5.2 finds missing. One thing to bear in mind is that eslint-plugin-jsx-a11y should be v5 instead of the latest (v6); otherwise each file creates a warning:

npm start

Compiled with warnings.

./src/index.js
  Line 1:  Definition for rule 'jsx-a11y/href-no-hash' was not found  jsx-a11y/href-no-hash

./src/registerServiceWorker.js
  Line 11:  Definition for rule 'jsx-a11y/href-no-hash' was not found  jsx-a11y/href-no-hash

./src/App.js

  Line 1:  Definition for rule 'jsx-a11y/href-no-hash' was not found  jsx-a11y/href-no-hash

Search for the keywords to learn more about each warning.
To ignore, add // eslint-disable-next-line to the line before.

Here's a one-liner hack that temporary helped me npm start without downgrading npm to v4:

npm install --save-dev eslint-plugin-import eslint-plugin-react eslint-plugin-flowtype eslint-plugin-jsx-a11y@5

@Timer
Copy link
Contributor

Timer commented Jul 13, 2017

Here's a one-liner hack that temporary helped me npm start without downgrading npm to v4

May I ask why you're against downgrading to npm v4?

npm@5 was a rushed release so that it could be included with Node 8; I would not expect it to be stable for some time.
In the interim, I'd continue to use npm@4 or Yarn if you're concerned about having a Lockfile.

Please file bugs with npm too so they can fix.

I'm not sure what the npm cli team is really doing -- for example, 5.2.0 was released which contained this issue's bug; they reverted the commit but have not made a patch release, leaving people to suffer with this problem for days.

I would not expect the npm cli team to be pressed by any authority until Node 8 is about to enter LTS.

@aleix10kst
Copy link

I've tried with npm v4 and I confirm it works. I had the same issue, so downgrading to v4 it takes only 20 secs and it's the "best" solution...

@gaearon
Copy link
Contributor

gaearon commented Jul 13, 2017

I can empathize with npm here because the only way they can find bugs after a rewrite is by pushing out releases and fixing regressions. I’m hopeful that it should get better after 5.2.1.

@Timer
Copy link
Contributor

Timer commented Jul 13, 2017

I'd like to stress that I'm very grateful for the effort the npm team puts in.
I do not want to undermine what they're doing in any way; I just wish they'd push bug fixes on a slightly quicker-schedule since so many people are already treating it as stable.

I hope I didn't come off too aggressive.

@kachkaev
Copy link

All worked for me after upgrading to npm 5.3. Can anyone else confirm please?

@AlexeyGorokhov
Copy link

Upgrading to npm@5.3.0 solves the problem.

@piotr-cz
Copy link
Contributor

Upgrade to npm v5.3.0 didin't work for me, I had to switch to yarn

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests