Work around Jest environment resolving bug #4247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
force-pushed
the
workaround-jest-issue
branch
from
64c2c71
to
c196240
Compare
|
Auch, hacky... I do think it's best to do it this way for now |
gaearon
added a commit
that referenced
this pull request
Apr 3, 2018
bors bot
added a commit
to mythmon/corsica-tree-status
that referenced
this pull request
Apr 23, 2018
3: Update dependency flow-bin to v0.70.0 r=mythmon a=renovate[bot] This Pull Request updates dependency [flow-bin](https://github.com/flowtype/flow-bin) from `v0.66.0` to `v0.70.0` <details> <summary>Commits</summary> #### v0.67.1 - [`4255e2d`](flow/flow-bin@4255e2d) v0.67.1 #### v0.68.0 - [`aea9bb5`](flow/flow-bin@aea9bb5) v0.68.0 #### v0.69.0 - [`b8a5da6`](flow/flow-bin@b8a5da6) v0.69.0 #### v0.70.0 - [`0b0bcea`](flow/flow-bin@0b0bcea) v0.70.0 </details> --- This PR has been generated by [Renovate Bot](https://renovateapp.com). 4: Update dependency react-scripts to v1.1.4 r=mythmon a=renovate[bot] This Pull Request updates dependency [react-scripts](https://github.com/facebookincubator/create-react-app) from `v1.1.1` to `v1.1.4` <details> <summary>Release Notes</summary> ### [`v1.1.2`](https://github.com/facebookincubator/create-react-app/blob/master/CHANGELOG.md#​112-April-3-2018) ##### 🐛 Bug Fix * `react-scripts` * [#​4085](`facebook/create-react-app#4085) Resolve `.js` before `.mjs` files to unbreak dependencies with native ESM support. ([@​leebyron]) ##### 📝 Documentation * `react-scripts` * [#​4197](`facebook/create-react-app#4197) Add troubleshooting for Github Pages. ([@​xnt]) ##### Committers: 2 - Lee Byron ([leebyron]) - Vicente Plata ([xnt]) ##### Migrating from 1.1.1 to 1.1.2 Inside any created project that has not been ejected, run: ``` npm install --save --save-exact react-scripts@​1.1.2 ``` or ``` yarn add --exact react-scripts@​1.1.2 ``` --- ### [`v1.1.3`](https://github.com/facebookincubator/create-react-app/blob/master/CHANGELOG.md#​113-April-3-2018) ##### 🐛 Bug Fix * `react-scripts` * [#​4247](`facebook/create-react-app#4247) Fix `environment.dispose is not a function` error caused by a Jest bug. ([@​gaearon]) ##### Committers: 1 - Dan Abramov ([gaearon]) ##### Migrating from 1.1.2 to 1.1.3 Inside any created project that has not been ejected, run: ``` npm install --save --save-exact react-scripts@​1.1.3 ``` or ``` yarn add --exact react-scripts@​1.1.3 ``` --- ### [`v1.1.4`](https://github.com/facebookincubator/create-react-app/blob/master/CHANGELOG.md#​114-April-3-2018) ##### 🐛 Bug Fix * `react-dev-utils` * [#​4250](`facebook/create-react-app#4250) Upgrade `detect-port-alt` to fix [#​4189](`facebook/create-react-app#4189). ([@​Timer]) ##### Committers: 1 - Joe Haddad ([Timer]) ##### Migrating from 1.1.3 to 1.1.4 Inside any created project that has not been ejected, run: ``` npm install --save --save-exact react-scripts@​1.1.4 ``` or ``` yarn add --exact react-scripts@​1.1.4 ``` --- </details> <details> <summary>Commits</summary> #### v1.1.2 - [`058d03f`](facebook/create-react-app@058d03f) Fix typos in example monorepo documentation. (#​4164) - [`1922f4d`](facebook/create-react-app@1922f4d) Allow ModuleScopePlugin accecpts an array as its appSrc (#​4138) - [`33f1294`](facebook/create-react-app@33f1294) Revert "Change no-unused-vars 'args' from none to all to show warning on destructured objects" - [`8a34b7c`](facebook/create-react-app@8a34b7c) Add ESLint check for incorrect propTypes usage (#​3840) (#​4048) - [`8db5e33`](facebook/create-react-app@8db5e33) Revert lint-related changes made in #​4193 (#​4211) - [`06dd17e`](facebook/create-react-app@06dd17e) add `create-react-app --help` info for local file path `--scripts-version` support (#​4015) - [`9c167a4`](facebook/create-react-app@9c167a4) Add some stuff that requires transpilation. (#​4174) - [`da518d2`](facebook/create-react-app@da518d2) Fix floating caret position incorrect while scrolling overlay (#​4024) - [`2824bf2`](facebook/create-react-app@2824bf2) [next] Revert to use ecma 5 in uglifyOptions (#​4234) - [`9a99b5d`](facebook/create-react-app@9a99b5d) Fix typo and be clearer about `ecma` settings in uglifyjs options (#​4239) - [`9c3f03c`](facebook/create-react-app@9c3f03c) use the lastest url of gitignore file (#​4236) #### v1.1.3 - [`061d1e4`](facebook/create-react-app@061d1e4) Add troubleshooting for Github Pages (#​4197) - [`2e690e9`](facebook/create-react-app@2e690e9) Add 1.1.2 changelog (#​4242) #### v1.1.4 - [`3b102fe`](facebook/create-react-app@3b102fe) Work around Jest environment resolving bug (#​4247) - [`90c908e`](facebook/create-react-app@90c908e) Changelog for 1.1.3 - [`2762924`](facebook/create-react-app@2762924) Update detect-port-alt </details> --- This PR has been generated by [Renovate Bot](https://renovateapp.com). Co-authored-by: Renovate Bot <bot@renovateapp.com>
vojtechsimetka
added a commit
to Giveth/create-react-app
that referenced
this pull request
May 28, 2018
* 'master' of https://github.com/facebook/create-react-app: (220 commits) Publish Changelog for 1.1.4 Update detect-port-alt (facebook#4250) Publish Changelog for 1.1.3 Work around Jest environment resolving bug (facebook#4247) Publish Add 1.1.2 changelog (facebook#4242) Add troubleshooting for Github Pages (facebook#4197) `.mjs` should not resolve before .js files (facebook#4085) Publish Revert "Set the public path to the asset manifest entries (facebook#2544)" Add 1.1.1 changelog Unpin and bump fsevents (for 1.x branch) (facebook#4006) Update dotenv-expand to fix bug with environment variables that contain a $. (facebook#4000) Update instructions for continuous delivery with Netlify (facebook#3971) Include `{json,css}` files in prettier command (facebook#3894) Set the public path to the asset manifest entries (facebook#2544) 1.5.1 pin envinfo version to 3.4.2 (facebook#3853) ... # Conflicts: # packages/react-scripts/config/webpack.config.prod.js # packages/react-scripts/package.json
Pavek
pushed a commit
to Pavek/create-react-app
that referenced
this pull request
Jul 10, 2018
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this pull request
Aug 14, 2018
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this pull request
Sep 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very hacky workaround for jestjs/jest#5913. I think we need this because it's actively breaking our users (lint-staged/lint-staged#414) and is very tricky to debug.
cc @SimenB