Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark DestructorThread as a daemon #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jxtps
Copy link

@jxtps jxtps commented Aug 18, 2021

Mark DestructorThread as a daemon so the JVM can exit.

Motivation

Why are you making this change?
To fix #25

Summary

What did you change?
I added sThread.setDaemon(true), which marks the destructor thread as a so called 'daemon' thread so it doesn't stop the JVM from exiting when all (other) user threads have terminated.

How does the code work?
It marks the thread as a daemon (a opposed to user) thread. The JVM keeps running until all user threads exit. This thread never exits.

Why did you choose this approach?
Because this is a textbook daemon thread.

Test Plan

How did you test this change?
See @dreiss code example in #25

Mark DestructorThread as a daemon so the JVM can exit.
@facebook-github-bot
Copy link
Contributor

Hi @jxtps!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 18, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link
Contributor

@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@mrousavy
Copy link
Contributor

Hey - has this ever been imported & merged internally?

@cortinico
Copy link
Contributor

Hey - has this ever been imported & merged internally?

Nope. It had a bunch of failures internally and was never merged. @passy can tell more here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JVM doesn't terminate when using Hybrids
4 participants