Move fbjni tests into fbjni directory #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbshipit-source-id: 30e4bb76d748f135bfa3619f62983ee39bf9969c
Summary: Want these to be included in Open Source fbjni. Differential Revision: D17139151 fbshipit-source-id: 4d28c59f27c8585d1aa13c7ebbfe8b141b945523
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Sep 4, 2019
Summary: Pull Request resolved: facebookincubator/fbjni#2 Want these to be included in Open Source fbjni. Reviewed By: passy Differential Revision: D17139151 fbshipit-source-id: 18d549fa4cbcc6860e9804abe2b8acdeb405d082
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 4, 2019
Summary: Pull Request resolved: #2 Want these to be included in Open Source fbjni. Reviewed By: passy Differential Revision: D17139151 fbshipit-source-id: 18d549fa4cbcc6860e9804abe2b8acdeb405d082
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 3, 2020
Summary:
With the `__cxa_throw` hook attached for gnustl, apps will crash if an object without a destructor is thrown:
```
try { throw 0; } catch(...) {}
// or
class SimpleException {};
try { throw SimpleException{}; } catch(...) {}
```
The issue is that the `__cxa_throw` abi has a destructor function pointer parameter, which may be null according to the documentation. In the gnustl region of the code, Lyra doesn't do a null check before invoking it at the following stack:
```
[???] 0X0 [unknown] + 0x0
+libfbjni.so facebook::lyra::(anonymous namespace)::HijackedExceptionTypeInfo::destructor(void*) (./fbandroid/libraries/fbjni/cxx/lyra/cxa_throw.cpp:213)
libgnustl_shared.so 0X759F86716C [unknown] + 0x6116c
libgnustl_shared.so 0X759F8DD2E0 _Unwind_DeleteException + 0x18
```
I wrote a test which repros the issue, and without the fix it crashes with a similar stack:
```
backtrace:
#00 pc 00000000 <unknown>
#1 pc 00022e01 /data/app/com.facebook.builds.fb4a-vhhkGO4NTAZmUTmfS5wpfw==/lib/arm/libfbjni.so (BuildId: 7a0f9db0801e4f451162c28a392cd35d4ba46b9a)
#2 pc 0004fb2d /data/app/com.facebook.lyra.tests-MJNqCBmU7StfOjPoAyfEgg==/lib/arm/libgnustl_shared.so!libgnustl_shared.so (offset 0x4f000) (BuildId: 059ab3ea3d764339fe3ceea2904f54637c89594e)
#3 pc 0009b8e3 /data/app/com.facebook.lyra.tests-MJNqCBmU7StfOjPoAyfEgg==/lib/arm/libgnustl_shared.so!libgnustl_shared.so (offset 0x50000) (_Unwind_DeleteException+12) (BuildId: 059ab3ea3d764339fe3ceea2904f54637c89594e)
#4 pc 0000aeb9 /data/app/com.facebook.lyra.tests-MJNqCBmU7StfOjPoAyfEgg==/lib/arm/liblyra-tests.so (testThatCxaThrowHookThrowsAndSetsTraceTrivialException(facebook::jni::alias_ref<_jclass*>)+220) (BuildId: 31cc0552d685f1ce9e896d1628656cd97096678d)
```
To fix, add a null check before invoking `mutable_info->orig_dest_`, which originates from the destructor parameter.
Reviewed By: smeenai
Differential Revision: D20841003
fbshipit-source-id: 907a13ebf994c5bad511b13ab9684efcbc2ce474
EduardoCostaom
pushed a commit
to EduardoCostaom/profilo
that referenced
this pull request
Nov 2, 2022
Summary: Pull Request resolved: facebookincubator/fbjni#2 Want these to be included in Open Source fbjni. Reviewed By: passy Differential Revision: D17139151 fbshipit-source-id: 18d549fa4cbcc6860e9804abe2b8acdeb405d082
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Want these to be included in Open Source fbjni.
Differential Revision: D17139151