Skip to content

Commit

Permalink
Fix build failure with CMake (#116)
Browse files Browse the repository at this point in the history
Summary:
Without this, the build fails with

```
  Undefined symbols for architecture arm64:
    "fizz::extensions::generateDelegatedCredentialPEM(fizz::extensions::DelegatedCredential, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >)", referenced from:
        fizz::tool::fizzGenerateDelegatedCredentialCommand(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) in FizzGenerateDelegatedCredentialCommand.cpp.o
  ld: symbol(s) not found for architecture arm64
  clang: error: linker command failed with exit code 1 (use -v to see invocation)
```

This was missed in 19dca4c.

See https://github.com/Homebrew/homebrew-core/actions/runs/8932339958/job/24536092094?pr=170668#step:3:326

Pull Request resolved: #116

Reviewed By: frqiu

Differential Revision: D57024059

Pulled By: mingtaoy

fbshipit-source-id: 0788db522ebd4ab516636415012e51316238ed96
  • Loading branch information
carlocab authored and facebook-github-bot committed May 7, 2024
1 parent 05c9959 commit b21c619
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions fizz/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ set(FIZZ_SOURCES
extensions/delegatedcred/DelegatedCredentialCertManager.cpp
extensions/delegatedcred/DelegatedCredentialClientExtension.cpp
extensions/delegatedcred/DelegatedCredentialFactory.cpp
extensions/delegatedcred/DelegatedCredentialPemUtils.cpp
extensions/delegatedcred/DelegatedCredentialUtils.cpp
extensions/delegatedcred/Types.cpp
extensions/exportedauth/ExportedAuthenticator.cpp
Expand Down

0 comments on commit b21c619

Please sign in to comment.