Skip to content

Commit

Permalink
--shared-libs should be a common argument
Browse files Browse the repository at this point in the history
Summary:
X-link: facebookincubator/zstrong#848

Because it should work with `show-inst-dir`, otherwise we can't
calculate the right project hash.

Reviewed By: chadaustin

Differential Revision: D58011867

fbshipit-source-id: d8960b4a993efbada8e27584e56976279fcd6b43
  • Loading branch information
Simon Marlow authored and facebook-github-bot committed Jun 1, 2024
1 parent a9aff21 commit c9af85d
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions build/fbcode_builder/getdeps.py
Original file line number Diff line number Diff line change
Expand Up @@ -810,12 +810,6 @@ def setup_project_cmd_parser(self, parser):
),
action="append",
)
parser.add_argument(
"--shared-libs",
help="Build shared libraries if possible",
action="store_true",
default=False,
)
parser.add_argument(
"--free-up-disk",
help="Remove unused tools and clean up intermediate files if possible to maximise space for the build",
Expand Down Expand Up @@ -1326,6 +1320,12 @@ def add_common_arg(*args, **kwargs):
action="store_false",
dest="facebook_internal",
)
add_common_arg(
"--shared-libs",
help="Build shared libraries if possible",
action="store_true",
default=False,
)
add_common_arg(
"--allow-system-packages",
help="Allow satisfying third party deps from installed system packages",
Expand Down

0 comments on commit c9af85d

Please sign in to comment.