-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
failed when build with vs2019 Microsoft Visual Studio Community 2019 16.9.2 #59
Comments
1、follow the step described in README.md file on ubuntu platform, there's no error. the build procedure is successed。 |
According to the documentation, this is a parser error (looks like it's choking on a macro). Given that the macro is valid, I figure it's a bug with the compiler itself. Is this error happening while building the BogoShim/FizzTool specifically? Are you also building tests? |
thanks for you reply. |
I have been running into this same issue with VS Professional 2019 16.9.5. Per the documentation link reanimus provided it was suggested to turn off all optimizations. Optimizations were already turned off, so no luck there. However, the documentations suggested turning on /P to look at the preprocessor output. Just adding the /P option changed the behavior of the compiler enough to make the error go away. EDIT: A little premature on the victory lap. Success in getting the preprocessor output, but not the actual compilation. |
Was able to get this to get this to compile and run by substituting the problematic macro with the output from the preprocessor. |
@RTCaylorASC can you please elaborate on what to replace FizzBase.h:148 with / show a PR? Many thanks :) |
FWIW, I'm trying to build with the latest version of MSVC (16.10.0), but I'm currently blocked by an error when trying to build Boost... |
I found the problematic macro invocation in FizzBase.h starting at line 133...
FIZZ_DECLARE_VARIANT_TYPE(PendingEvent, FIZZ_PENDING_EVENT) Then I turned on the preprocessor output in my CMakeLits.txt file...
Then copied the macro equivalent from the preprocessor results in FizzClientCommand.i and then replaced the ugly macro in FizzBase.h...
|
@RTCaylorASC thank you very much! |
@reanimus i use the boost 1.75, and it is working well, means there is no error about boost |
Summary: MSVC does not like our FIZZ_DECLARE_VARIANT invocation within a class. #59 Reviewed By: anqixu, knekritz Differential Revision: D31866986 fbshipit-source-id: dd910b0dd52fcb342f1a0678e467c8beae3a99ac
Thanks @RTCaylorASC for the detailed investigation! This should be mitigated by 4db1d61 |
“F:\quicNew\fizz\fizz/protocol/FizzBase.h(150,3): fatal error C1001: Internal compiler error.
(compiler file ‘msc1.cpp’, line 1588)”
To work around this problem, try simplifying or changing the program near the locations listed above.
If possible please provide a repro here: https://developercommunity.visualstudio.com
Please choose the Technical Support command on the Visual C++
Help menu, or open the Technical Support help file for more information
The text was updated successfully, but these errors were encountered: