Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

passing optional as this discards qualifiers #7

Closed
fxbrain opened this issue Aug 11, 2018 · 2 comments
Closed

passing optional as this discards qualifiers #7

fxbrain opened this issue Aug 11, 2018 · 2 comments

Comments

@fxbrain
Copy link

fxbrain commented Aug 11, 2018

fizz/fizz/protocol/test/ProtocolTest.h:135:5 passing ‘const folly::Optional’ as ‘this’ argument discards qualifiers.

EXPECT_CALL(*ret, setSkipFailedDecryption(*skipFailedDecryption));

may be defined as:

EXPECT_CALL(*ret, setSkipFailedDecryption(skipFailedDecryption.value()));

to successfully compile the tests, since setSkipFailedDecryption in EncryptedRecordLayer.h expects bool.
facebook-github-bot pushed a commit that referenced this issue Aug 13, 2018
@knekritz @facebook-github-bot
Fix test compilation issue.
3032b10 
Summary:
As reported in #7

Note I cannot repro, but doing this won't hurt.

Reviewed By: ngoyal

Differential Revision: D9304812

fbshipit-source-id: ab71af8f5300084560d8593c1772de4bb79ad4ea
@mingtaoy
Copy link
Contributor

@fxbrain , what compiler were you using?

@knekritz
Copy link
Contributor

I made this change in 3032b10. Let me know if anything else is required (this issue does not repro in any of the platforms we are compiling on).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fxbrain @knekritz @mingtaoy