Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build breaks because of missing liboqs #79

Closed
jmccl opened this issue Aug 13, 2022 · 2 comments
Closed

Build breaks because of missing liboqs #79

jmccl opened this issue Aug 13, 2022 · 2 comments

Comments

@jmccl
Copy link

jmccl commented Aug 13, 2022

#include <oqs/kem.h> fails in the new file, OQSKeyExchange.h

https://github.com/facebookincubator/fizz/blob/7c31f0ab328d759c959e8307db0aee33e7e2388d/fizz/experimental/crypto/exchange/OQSKeyExchange.h

@mkyybx
Copy link
Contributor

mkyybx commented Aug 13, 2022

Seems like it's caused by fizz tool including the experimental oqs implementation. Will try to use macros to disable it.

facebook-github-bot pushed a commit that referenced this issue Aug 15, 2022
Summary: liboqs is still experimental and is not configured in cmake. This caused error when compiling the fizz tool (#79). Now we add a macro FIZZ_TOOL_ENABLE_OQS to control oqs-related stuff outside the experimental directory and it will be disabled by default.

Reviewed By: AjanthanAsogamoorthy

Differential Revision: D38694594

fbshipit-source-id: fd4f696d31f24bdf244b2f1e08a8506b5149e884
@mkyybx
Copy link
Contributor

mkyybx commented Aug 15, 2022

That commit should've fixed that. I will close the issue now and should you still have trouble compiling, please feel free to reopen this issue.

@mkyybx mkyybx closed this as completed Aug 15, 2022
carlocab added a commit to chenrui333/homebrew-core that referenced this issue Aug 16, 2022
carlocab added a commit to owine/homebrew-core that referenced this issue Aug 16, 2022
BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this issue Aug 17, 2022
* fizz: revision bump (fmt 9.0.0)
* fizz 2022.08.15.00
* fizz: disable `liboqs`
  facebookincubator/fizz#79

Signed-off-by: Rui Chen <rui@chenrui.dev>
Co-authored-by: Rui Chen <rui@chenrui.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants