Add gflags headers to tests #17
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thanks! Can you instead #include <folly/portability/GFlags.h>? |
This commit fixes some compilation issues for ClientSocket, ServerSocket and BogoShim tests due to missing gflags definitions.
bencord0
force-pushed
the
add_gflags_headers
branch
from
26e846e
to
d0d4167
Compare
There was a problem hiding this comment.
knekritz has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This commit fixes some compilation issues for ClientSocket, ServerSocket
and BogoShim tests due to missing gflags/gflags.h definitions.