Adapt fizz OpenSSL hash implementations #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Adapted SHA implementations and removed OpenSSL dependency from HandshakeContext so that HandshakeContext can be used with non-OpenSSL hash implementations. Reviewed By: knekritz Differential Revision: D14781837 fbshipit-source-id: 17d01cd1710e7a5564e280c782418964f9cd7140
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 22, 2020
Summary: As per actions/runner-images#709 there started to be some issies with Ubuntu envs running out of space. This should fix it. Also our Cargo builds use a lot of space, changing them to be non-incremental and removing debug symbols keeps the build fast, but greatly reduces the disk space usage leaving us enough space on GitHub Actions virtual machines. Pull Request resolved: facebook/sapling#23 Reviewed By: farnz Differential Revision: D22160020 Pulled By: lukaspiatkowski fbshipit-source-id: c23393e310c15ebf5a18b80f0bb5f1f894d24849
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Adapted SHA implementations and removed OpenSSL dependency from HandshakeContext so that HandshakeContext can be used with non-OpenSSL hash implementations.
Reviewed By: knekritz
Differential Revision: D14781837