libfmt is a dependency of Folly #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Building Folly fails if libfmt (https://github.com/fmtlib/fmt) is not available.
Summary: Modify `mac-build.sh` to run `make` with -j$NCPU flag, where $NCPU is the number of cores as reported by macOS. The speed-up was measured to be x2 on Dual-Core Intel Core i5.
There was a problem hiding this comment.
@ngoyal has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thanks for doing this! It looks like #47 is a subset of this PR, so we can probably close that one if this one works out. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 18, 2020
Summary: This test fails on i686 and armv7hl: ``` 54/66 Test #46: TypesTest ............................Child aborted***Exception: 0.19 sec [==========] Running 5 tests from 1 test suite. [----------] Global test environment set-up. [----------] 5 tests from TestTypes [ RUN ] TestTypes.WriteAndRead24BitsNormal [ OK ] TestTypes.WriteAndRead24BitsNormal (0 ms) [ RUN ] TestTypes.Write24BitsOverflow [ OK ] TestTypes.Write24BitsOverflow (0 ms) [ RUN ] TestTypes.Write24BitsBuffer [ OK ] TestTypes.Write24BitsBuffer (0 ms) [ RUN ] TestTypes.Write24BitsBufferOverflow F1116 16:18:08.078014 67 IOBuf.h:678] Check failed: amount <= tailroom() (4294967295 vs. 4) *** Check failure stack trace: *** *** Aborted at 1605572288 (Unix time, try 'date -d 1605572288') *** *** Signal 6 (SIGABRT) (0x43) received by PID 67 (pthread TID 0xf4e43b80) (linux TID 67) (maybe from PID 67, UID 0) (code: -6), stack trace: *** (error retrieving stack trace) ``` Rewrite the test to use a buffer just large enough to hold 24 bits. Reviewed By: knekritz Differential Revision: D25010436 fbshipit-source-id: 551d87b59674767fa189f464efbf0b5dc16ae1ff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build script mac-build.sh does not install libfmt even though it's a dependency of Folly, resulting in a broken build.
Fix: Add libfmt to the list of build dependencies.