Remove undefined bahaviour #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
control reaches end of non-void function warning. In case no label matches just return an empty string to avoid undefined beahviour.
mingtaoy
approved these changes
Jul 13, 2020
There was a problem hiding this comment.
Thanks for the patch. I think the real intention was to omit the default case so that -Werror=switch would compile-fail on a non-exhaustive switch. For non-debug builds, this should really be an exception, as returning an empty string would likely break the expected format.
There was a problem hiding this comment.
@mingtaoy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thanks @mingtaoy that -Wswitch use-case is quite useful I guess, my housemate actually suspected that was the case. My mvfst build was taking ages so I started looking at some of the warnings being spit out. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
control reaches end of non-void function warning. In case no label
matches just return an empty string to avoid undefined beahviour.