Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependencies #61

Closed
wants to merge 1 commit into from
Closed

Fix dependencies #61

wants to merge 1 commit into from

Conversation

autoantwort
Copy link
Contributor

Currently this lib does not expose the dependencies

@autoantwort autoantwort mentioned this pull request Jun 3, 2021
Merged
mingtaoy
mingtaoy requested changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@mingtaoy mingtaoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I left a few comments for you to address.

fizz/CMakeLists.txt Outdated Show resolved Hide resolved
fizz/CMakeLists.txt Outdated Show resolved Hide resolved
@autoantwort
Copy link
Contributor Author

I have incorporated the change requests

@facebook-github-bot
Copy link
Contributor

@mingtaoy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mingtaoy merged this pull request in 63692e7.

@mingtaoy
Copy link
Contributor

mingtaoy commented Jun 8, 2021

I've merged in your changes. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingtaoy mingtaoy mingtaoy requested changes

Assignees
No one assigned
Labels
CLA Signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@autoantwort @facebook-github-bot @mingtaoy