protocol/test: fix handshake secret compare #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@knekritz has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
|
@knekritz has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@TheDechev has updated the pull request. You must reimport the pull request before landing. |
TheDechev
force-pushed
the
fix_key_scheduler_typo
branch
from
8c14a09
to
49879dd
Compare
|
@TheDechev has updated the pull request. You must reimport the pull request before landing. |
|
I noticed some internal tests failed yesterday, how can I verify it locally? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a comparison between the same variable, instead of comparing the separate secret objects.