set IMPORTED_LINK_INTERFACE_LIBRARIES to ${LIBGFLAGS_LIBRARY} for glog::glog (#1854) #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g::glog (#1854) Summary: X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, the `glog` should solve the `GflagsFlagSaver` symbol from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Differential Revision: D39220438 fbshipit-source-id: e173e039d58725200ad14e3cb28b4ca41d71e3ac
|
This pull request was exported from Phabricator. Differential Revision: D39220438 |
Atry
added a commit
to Atry/wangle
that referenced
this pull request
Sep 1, 2022
…g::glog (#272) Summary: X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, the `glog` should solve the `GflagsFlagSaver` symbol from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Differential Revision: D39220438 fbshipit-source-id: 97f9809955bb473eb38c49d23708f30d25c325c8
Atry
added a commit
to Atry/reindeer
that referenced
this pull request
Sep 1, 2022
…g::glog (#272) Summary: X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, the `glog` should solve the `GflagsFlagSaver` symbol from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Differential Revision: D39220438 fbshipit-source-id: f924e27d0a0c2497eb5e11fab5bbaa8dbceec13b
Atry
added a commit
to Atry/hhvm
that referenced
this pull request
Sep 1, 2022
…g::glog (facebook#118) Summary: X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, the `glog` should solve the `GflagsFlagSaver` symbol from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Differential Revision: D39220438 fbshipit-source-id: fade756b0db0e1ccdb50dcc334ac345c0a8c54e5
facebook-github-bot
pushed a commit
to facebookincubator/hsthrift
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 Pull Request resolved: #98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 Pull Request resolved: #34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebookincubator/reindeer
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 Pull Request resolved: #4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 Pull Request resolved: #118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 Pull Request resolved: #521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 Pull Request resolved: #127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 Pull Request resolved: #1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebook/openr
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 Pull Request resolved: #140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 Pull Request resolved: #2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 Pull Request resolved: #31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebookexperimental/edencommon
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 Pull Request resolved: #4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 Pull Request resolved: #208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 Pull Request resolved: #272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: Pull Request resolved: #9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 Pull Request resolved: #1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since 4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 Pull Request resolved: #171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/folly#1854
X-link: facebook/openr#140
X-link: facebook/fb303#31
Previously Folly provided a polyfill of the
GflagsFlagSaversymbol, which was removed since facebook/folly@4dadde1. Therefore, theglogshould solve theGflagsFlagSaversymbol fromgflags.This diff added
gflagslibraries as a dependency of the CMake projectglog::glogintofbcode_builder'sFindGlog.cmake, so that thefbcode_builderusers will be able to automatically link withgflags.Differential Revision: D39220438