fix fizz build on arm64 #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SlidingBloomReplayCacheTest.cpp test was flaky, looks like the expiry can happen at exactly 1 second, moving to 1001 milliseconds fixed it. Updated associated comments to remove the time periods as was duplicative of the chrono call just below the comments Test Plan: Run locally ``` ./build/fbcode_builder/getdeps.py build --src-dir=. fizz ./build/fbcode_builder/getdeps.py test --src-dir=. fizz ``` before, fails with: ``` [==========] 5 tests from 1 test suite ran. (1115 ms total) [ PASSED ] 4 tests. [ FAILED ] 1 test, listed below: [ FAILED ] SlidingBloomReplayCacheTest.TestTimeBucketing 1 FAILED TEST ``` after, passes with: ``` 100% tests passed, 0 tests failed out of 68 Total Test time (real) = 1.07 sec ```
Summary: Build was broken on arm64 ubuntu 22.04 due to unconditional use of aes/sse3 code Used the same cmake logic as folly does to conditionally include the files on x86_64 only Test Plan: Local build with: ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. fizz Before, broken: ``` cc: error: unrecognized command-line option ‘-maes’ cc: error: unrecognized command-line option ‘-mssse3’ ``` After, works
|
alternative fix was merged in a5f718a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix fizz build on arm64
Summary:
Build was broken on arm64 ubuntu 22.04 due to unconditional use of aes/sse3 code
Used the same cmake logic as folly does to conditionally include the files on x86_64 only
Test Plan:
Local build with:
./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. fizz
Before, broken:
After, works
Stack created with Sapling. Best reviewed with ReviewStack.