Skip to content
This repository has been archived by the owner on Jan 10, 2024. It is now read-only.

typescript: Map.get support added #75

Closed

Conversation

abobr
Copy link

@abobr abobr commented Jan 30, 2019

Fixing the issue: #74

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

* DeepRequiredMap
* Nested Map condition handler
*/
type DeepRequiredMap<K, V> = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be an extension of the Map interface?

@mohsen1
Copy link
Contributor

mohsen1 commented Feb 7, 2019

if we add support for Map we should add support for Set too. Not sure about WeakMap and WeakSet

@yungsters
Copy link
Contributor

Thanks for taking the time to contribute this pull request and sign the CLA.

However, this was intentionally unsupported by idx. IIRC, we intentionally kept the contract of idx to simple member expressions because of non-trivial considerations for order of execution, etc.

Given that optional chaining is a formal active proposal now, I'm also reluctant to increase the scope of idx. I hope this makes sense.

@yungsters yungsters closed this Feb 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants