Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode Badge text color contrast is bad #265

Open
hasezoey opened this issue Jun 23, 2022 · 3 comments
Open

Dark mode Badge text color contrast is bad #265

hasezoey opened this issue Jun 23, 2022 · 3 comments

Comments

@hasezoey
Copy link

Currently the default Text color for badges in dark mode is way too white, which is not good to read:
badges_now

But i had tried changing the text color to the same the buttons are set now:
buttons_now

which would be the change of [data-theme='dark'] {--ifm-badge-color: var(--ifm-font-color-base-inverse);}, which would look like:
badges_changed
(Note: the Secondary overwrite is still in place for this screenshot)

this is just a small mockup (no testing or PR worthy) change but i think it is way better than just the white it was before

Tested and Screenshots from Linux Manjaro 21.3.0 with Firefox 101.0.1 on KDE Plasma Wayland


This issue is related to #192, but about a more specific part of it

@Josh-Cena
Copy link
Contributor

Maybe you should override --ifm-color-secondary in dark mode, just like the docs suggest for the primary color? I certainly don't like the current palette.

@hasezoey
Copy link
Author

Maybe you should override --ifm-color-secondary in dark mode

this issue is not specifically about secondary color, i just noted that i left the overwrite inplace and did not remove it, this issue is about that all other badges have white text in dark mode which does not contrast well

@pixelass
Copy link

pixelass commented May 3, 2024

I added a comment here that might help: #139 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants