Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document text utility classes. #304

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

homotechsual
Copy link
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 3, 2024
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for infima ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 78600f2
🔍 Latest deploy log https://app.netlify.com/sites/infima/deploys/660d36f6621aa700089960b2
😎 Deploy Preview https://deploy-preview-304--infima.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@slorber
Copy link
Collaborator

slorber commented Apr 4, 2024

LGTM thanks 👍

@slorber
Copy link
Collaborator

slorber commented Apr 4, 2024

Note: it's not super important to invest time in document those because sooner or later I'll merge back Infima into theme classic and cleanup everything we don't use. Infima will become an internal implementation detail rather than a public API recommended to use.

@slorber slorber merged commit 6e3cd64 into facebookincubator:main Apr 4, 2024
3 of 5 checks passed
@homotechsual
Copy link
Contributor Author

Note: it's not super important to invest time in document those because sooner or later I'll merge back Infima into theme classic and cleanup everything we don't use. Infima will become an internal implementation detail rather than a public API recommended to use.

When that happens would we want to move documentation on the theme framework classes to the Docusaurus documentation anyway to make it easier for folks writing custom components/plugins to reuse theme-classic provided classes if they wish?

@slorber
Copy link
Collaborator

slorber commented Apr 4, 2024

to make it easier for folks writing custom components/plugins to reuse theme-classic provided classes

Actually I want to avoid that. If we introduce a theme-classic-tailwind later those Infima classes won't exist. Plugins need to be independent, and one plugin should rather not use classes coming from another.

Plugins like search etc should rather use CSS Modules instead of Infima

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants