This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
[smt2parser] Add support for name resolution #27
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a working implementation of name resolution and name normalization for SMT2 files with the following caveats:
is-Foo
is not compatible with name resolution. One needs to replaceis-Foo
into(_ is Foo)
first using the given rewriterrenaming::TesterModernizer
(see unit tests).Result
yet and willpanic!
in case of unknown symbol. (However, this only affects people using the new name-resolution callbacks, not the parsing.)SyntaxBuilder
first, then visit the concrete syntax again. See the unit test of the utility typerenaming::SymbolNormalizer
.