fix veloxminiapp

facebookincubator · May 22, 2024 · 7681904 · 7681904
1 parent 2917528
commit 7681904
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 9 deletions.
diff --git a/velox/examples/CMakeLists.txt b/velox/examples/CMakeLists.txt
@@ -12,6 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+add_subdirectory(veloxminiapp)
+
 add_executable(velox_example_simple_functions SimpleFunctions.cpp)
 
 target_link_libraries(velox_example_simple_functions velox_functions_lib

diff --git a/velox/examples/veloxminiapp/CMakeLists.txt b/velox/examples/veloxminiapp/CMakeLists.txt
@@ -12,14 +12,13 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-add_executable(
-  velox_mini_app VeloxMiniApp.cpp ../../exec/tests/utils/Cursor.cpp
-                 ../../exec/tests/utils/PlanBuilder.cpp)
+add_executable(velox_mini_app VeloxMiniApp.cpp)
 
 target_link_libraries(
   velox_mini_app
   velox_core
   velox_hive_connector
+  velox_exec_test_lib
   velox_tpch_connector
   velox_parse_parser
   velox_functions_prestosql

diff --git a/velox/examples/veloxminiapp/VeloxMiniApp.cpp b/velox/examples/veloxminiapp/VeloxMiniApp.cpp
@@ -3,7 +3,7 @@
 #include "velox/connectors/hive/HiveConnectorSplit.h"
 #include "velox/dwio/parquet/reader/ParquetReader.h"
 #include "velox/exec/PlanNodeStats.h"
-#include "velox/exec/tests/utils/Cursor.h"
+#include "velox/exec/tests/utils/QueryAssertions.h"
 #include "velox/exec/tests/utils/PlanBuilder.h"
 #include "velox/functions/prestosql/aggregates/RegisterAggregateFunctions.h"
 #include "velox/functions/prestosql/registration/RegistrationFunctions.h"
@@ -46,17 +46,17 @@ int main(int argc, char** argv) {
   auto filePath = argv[1];
   auto pool = memory::memoryManager()->addLeafPool();
   auto selectedRowType =
-      ROW({"binary_field"},
-          {VARCHAR()});
+      ROW({"flba_field"},
+          {VARBINARY()});
 
   core::PlanNodeId lineitemPlanNodeId;
   auto plan =
       exec::test::PlanBuilder(pool.get())
           .tableScan(
               selectedRowType)
           .capturePlanNodeId(lineitemPlanNodeId)
-          .project({"l_extendedprice * l_discount"})
-          .partialAggregation({}, {"sum(p0)"})
+        //  .project({"l_extendedprice * l_discount"})
+          .partialAggregation({}, {"min(flba_field)"})
           .localPartition(std::vector<std::string>{})
           .finalAggregation()
           .planNode();
@@ -86,7 +86,7 @@ int main(int argc, char** argv) {
   // Consume the results.
   assert(1 == resultVec.size());
   assert(1 == resultVec[0]->size());
-  auto result = resultVec[0]->childAt(0)->as<SimpleVector<double>>()->valueAt(0);
+  auto result = resultVec[0]->childAt(0)->as<SimpleVector<StringView>>()->valueAt(0);
   std::cout << "Result:" << result << std::endl;
   auto task = cursor->task();
   assert(task->isFinished());