Refactor AggregateCompanionAdapter to remove duplicate code

facebookincubator · May 24, 2024 · 7e4ee37 · 7e4ee37
1 parent a40ef80
commit 7e4ee37
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/velox/exec/AggregateCompanionAdapter.cpp b/velox/exec/AggregateCompanionAdapter.cpp
@@ -329,7 +329,8 @@ bool registerAggregateFunction(
     const std::string& name,
     const std::string& mergeExtractFunctionName,
     const std::vector<std::shared_ptr<AggregateFunctionSignature>>&
-        mergeExtractSignatures) {
+        mergeExtractSignatures,
+    bool overwrite) {
   return exec::registerAggregateFunction(
              mergeExtractFunctionName,
              std::move(mergeExtractSignatures),
@@ -387,7 +388,10 @@ bool CompanionFunctionsRegistrar::registerMergeExtractFunctionWithSuffix(
         CompanionSignatures::mergeExtractFunctionNameWithSuffix(name, type);
 
     registered |= registerAggregateFunction(
-        name, mergeExtractFunctionName, std::move(mergeExtractSignatures));
+        name,
+        mergeExtractFunctionName,
+        std::move(mergeExtractSignatures),
+        overwrite);
   }
   return registered;
 }
@@ -410,7 +414,10 @@ bool CompanionFunctionsRegistrar::registerMergeExtractFunction(
   auto mergeExtractFunctionName =
       CompanionSignatures::mergeExtractFunctionName(name);
   return registerAggregateFunction(
-      name, mergeExtractFunctionName, std::move(mergeExtractSignatures));
+      name,
+      mergeExtractFunctionName,
+      std::move(mergeExtractSignatures),
+      overwrite);
 }
 
 VectorFunctionFactory getVectorFunctionFactory(