Fix compile issue

facebookincubator · Jan 15, 2024 · be9f06c · be9f06c
1 parent cddc99b
commit be9f06c
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/velox/exec/tests/utils/QueryAssertions.cpp b/velox/exec/tests/utils/QueryAssertions.cpp
@@ -249,6 +249,14 @@ variant variantAt<TypeKind::TIMESTAMP>(
       dataChunk->GetValue(column, row).GetValue<::duckdb::timestamp_t>()));
 }
 
+template <>
+variant variantAt<TypeKind::UNKNOWN>(
+    ::duckdb::DataChunk* dataChunk,
+    int32_t row,
+    int32_t column) {
+  return variant::null(TypeKind::UNKNOWN);
+}
+
 template <TypeKind kind>
 variant variantAt(const ::duckdb::Value& value) {
   if (value.type() == ::duckdb::LogicalType::INTERVAL) {
@@ -263,6 +271,11 @@ variant variantAt(const ::duckdb::Value& value) {
   }
 }
 
+template <>
+variant variantAt<TypeKind::UNKNOWN>(const ::duckdb::Value& value) {
+  return variant::null(TypeKind::UNKNOWN);
+}
+
 template <>
 velox::variant variantAt<TypeKind::HUGEINT>(const ::duckdb::Value& value) {
   auto hugeInt = ::duckdb::HugeIntValue::Get(value);

diff --git a/velox/expression/CastExpr.cpp b/velox/expression/CastExpr.cpp
@@ -338,7 +338,7 @@ VectorPtr CastExpr::applyArray(
   return result;
 }
 
-// Cast from unkown type to other types.
+// Cast from unknown type to other types.
 VectorPtr CastExpr::applyUnknown(
     const SelectivityVector& rows,
     const BaseVector& /*input*/,

diff --git a/velox/functions/prestosql/aggregates/PrestoHasher.cpp b/velox/functions/prestosql/aggregates/PrestoHasher.cpp
@@ -116,6 +116,13 @@ FOLLY_ALWAYS_INLINE void PrestoHasher::hash(
   hashIntegral<T>(*vector_.get(), rows, hashes);
 }
 
+template <>
+FOLLY_ALWAYS_INLINE void PrestoHasher::hash<TypeKind::UNKNOWN>(
+    const SelectivityVector& rows,
+    BufferPtr& hashes) {
+  applyHashFunction(rows, *vector_.get(), hashes, [&](auto row) { return 0; });
+}
+
 template <>
 FOLLY_ALWAYS_INLINE void PrestoHasher::hash<TypeKind::BOOLEAN>(
     const SelectivityVector& rows,