Add tests

facebookincubator · Feb 11, 2024 · d35bc61 · d35bc61
1 parent 34972e4
commit d35bc61
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/velox/expression/tests/CastExprTest.cpp b/velox/expression/tests/CastExprTest.cpp
@@ -371,6 +371,19 @@ TEST_F(CastExprTest, basics) {
       {"1.888", "2.5", "3.6", "100.44", "-100.101", "1", "-2"});
 }
 
+TEST_F(CastExprTest, fromUnknownType) {
+  testCast<UnknownValue, int>(
+      "int", {std::nullopt, std::nullopt}, {std::nullopt, std::nullopt});
+  testCast<UnknownValue, float>(
+      "float", {std::nullopt, std::nullopt}, {std::nullopt, std::nullopt});
+  testCast<UnknownValue, double>(
+      "double", {std::nullopt, std::nullopt}, {std::nullopt, std::nullopt});
+  testCast<UnknownValue, std::string>(
+      "string", {std::nullopt, std::nullopt}, {std::nullopt, std::nullopt});
+  testCast<UnknownValue, bool>(
+      "boolean", {std::nullopt, std::nullopt}, {std::nullopt, std::nullopt});
+}
+
 TEST_F(CastExprTest, realAndDoubleToString) {
   setLegacyCast(false);
   testCast<double, std::string>(

diff --git a/velox/vector/arrow/tests/ArrowBridgeSchemaTest.cpp b/velox/vector/arrow/tests/ArrowBridgeSchemaTest.cpp
@@ -396,7 +396,6 @@ TEST_F(ArrowBridgeSchemaImportTest, complexTypes) {
 }
 
 TEST_F(ArrowBridgeSchemaImportTest, unsupported) {
-  // EXPECT_THROW(testSchemaImport("n"), VeloxUserError);
   EXPECT_THROW(testSchemaImport("C"), VeloxUserError);
   EXPECT_THROW(testSchemaImport("S"), VeloxUserError);
   EXPECT_THROW(testSchemaImport("I"), VeloxUserError);