Skip to content

Commit

Permalink
migrate from FOLLY_FALLTHROUGH to [[fallthrough]] (assorted) (#8558)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #8558

The attribute `[[fallthrough]]` is standard C++17. We no longer need to wrap it.

Reviewed By: Orvid

Differential Revision: D53034074

fbshipit-source-id: 19b1e8314e70f3e08882e76b93f7ded4df7ab9f2
  • Loading branch information
yfeldblum authored and facebook-github-bot committed Jan 29, 2024
1 parent 2d73886 commit f3b91e3
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions velox/exec/HashBuild.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -986,7 +986,7 @@ BlockingReason HashBuild::isBlocked(ContinueFuture* future) {
}
break;
case State::kWaitForBuild:
FOLLY_FALLTHROUGH;
[[fallthrough]];
case State::kWaitForProbe:
if (!future_.valid()) {
setRunning();
Expand Down Expand Up @@ -1036,11 +1036,11 @@ void HashBuild::checkStateTransition(State state) {
}
break;
case State::kWaitForBuild:
FOLLY_FALLTHROUGH;
[[fallthrough]];
case State::kWaitForSpill:
FOLLY_FALLTHROUGH;
[[fallthrough]];
case State::kWaitForProbe:
FOLLY_FALLTHROUGH;
[[fallthrough]];
case State::kFinish:
VELOX_CHECK_EQ(state_, State::kRunning);
break;
Expand Down

0 comments on commit f3b91e3

Please sign in to comment.