Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for EXTRACT Year from Date. This is used in 3 TPC-H queries. #228

Closed
aditi-pandit opened this issue Sep 16, 2021 · 4 comments
Closed

Add support for EXTRACT Year from Date. This is used in 3 TPC-H queries. #228

aditi-pandit opened this issue Sep 16, 2021 · 4 comments
Assignees
@aditi-pandit
Labels
TPC-H

Comments

@aditi-pandit
Copy link
Collaborator

TPC-H queries 7, 8, 9 group by a column that is obtained using EXTRACT Year from Date. Add support for this functionality in PrestoCPP.

Steps to reproduce : Run unit tests testTpchQ7(8)(9) in
java/presto-native-tests/src/test/java/com/facebook/presto/nativeworker/TestHiveTpchQueries.java

(The test also fails as DATE type is not supported for the EXTRACT functionality)
@frankobe frankobe assigned frankobe and unassigned frankobe Oct 6, 2021
@mbasmanova
Copy link
Contributor

Year function was added in 7ac665a

@aditi-pandit aditi-pandit reopened this Nov 4, 2021
@aditi-pandit
Copy link
Collaborator Author

EXTRACT YEAR is required from DATE type also for this work.

@aditi-pandit
Copy link
Collaborator Author

#627 extends Masha's PR for Date.

@aditi-pandit
Copy link
Collaborator Author

https://github.com/facebookexternal/presto_cpp/pull/578 enables the queries using extract(year from date) in the TPC-H tests.

@aditi-pandit aditi-pandit self-assigned this Nov 18, 2021
rui-mo pushed a commit to rui-mo/velox that referenced this issue Mar 17, 2023
@taiyang-li
[CH-225] Fix decimal bug cased by big-endian encoding in spark row. f…
3521995 
…acebookincubator#228 (facebookincubator#679)

Fix decimal bug cased by big-endian encoding in spark row. 

Related to [CH PR 228](Kyligence/ClickHouse#228)
rui-mo added a commit to rui-mo/velox that referenced this issue May 10, 2023
@rui-mo @Yuhta
Add back not node (facebookincubator#228)
caf39d9 
* Add back not node.

* Fix NOT handling in metadata filter.

---------

Co-authored-by: Jimmy Lu <jimmylu@meta.com>
Yohahaha pushed a commit to Yohahaha/velox that referenced this issue May 12, 2023
@rui-mo @Yuhta @zhejiangxiaomai
Add back not node (facebookincubator#228)
b03f9ec 
* Add back not node.

* Fix NOT handling in metadata filter.

---------

Co-authored-by: Jimmy Lu <jimmylu@meta.com>
PHILO-HE pushed a commit to PHILO-HE/velox that referenced this issue May 30, 2023
@rui-mo @Yuhta @zhejiangxiaomai
Add back not node (facebookincubator#228)
8c19d57 
* Add back not node.

* Fix NOT handling in metadata filter.

---------

Co-authored-by: Jimmy Lu <jimmylu@meta.com>
zhouyuan pushed a commit to zhouyuan/velox that referenced this issue Jun 6, 2023
@rui-mo @Yuhta @zhejiangxiaomai
Add back not node (facebookincubator#228)
da9ebc8 
* Add back not node.

* Fix NOT handling in metadata filter.

---------

Co-authored-by: Jimmy Lu <jimmylu@meta.com>
PHILO-HE pushed a commit to PHILO-HE/velox that referenced this issue Jun 27, 2023
@rui-mo @Yuhta @zhejiangxiaomai
Add back not node (facebookincubator#228)
45fe7ae 
* Add back not node.

* Fix NOT handling in metadata filter.

---------

Co-authored-by: Jimmy Lu <jimmylu@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aditi-pandit aditi-pandit

Labels
TPC-H
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@frankobe @mbasmanova @aditi-pandit