Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for more types in HivePartitionFunction #327

Closed
mbasmanova opened this issue Sep 28, 2021 · 11 comments
Closed

Add support for more types in HivePartitionFunction #327

mbasmanova opened this issue Sep 28, 2021 · 11 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mbasmanova
Copy link
Contributor

#314 introduced HivePartitionFunction to BIGINT and VARCHAR types. We need to add support for the rest of the types as well, e.g. TINYINT, SMALLINT, INTEGER, REAL, DOUBLE, TIMESTAMP and VARBINARY.

See https://github.com/prestodb/presto/blob/master/presto-hive/src/main/java/com/facebook/presto/hive/HiveBucketing.java#L147 for reference implementation in Presto.

CC: @pedroerp
@mbasmanova mbasmanova added good first issue Good for newcomers enhancement New feature or request labels Sep 28, 2021
@mbasmanova
Copy link
Contributor Author

CC: @amitkdutta

@thenotoriouscodefather
Copy link
Contributor

thenotoriouscodefather commented Oct 6, 2021 •
edited
Loading

@mbasmanova, I'd like to work on this feature.

@mbasmanova
Copy link
Contributor Author

@odilov Please, go ahead.

@usurai usurai mentioned this issue Apr 22, 2022
Closed
@usurai
Copy link
Contributor

usurai commented May 11, 2022

Hi @mbasmanova, I pushed a PR addressing this issue a while ago, it's my first in velox. Could you please tell if there is anything I need to do to get it into review process? I've sent email to velox@fb.com to request access to the OSS slack workspace but haven't hear reply. Thanks!

@mbasmanova
Copy link
Contributor Author

CC: @jijufb Jiju, would you help @usurai get access to Slack?

@mbasmanova
Copy link
Contributor Author

@usurai Would you share a link to the PR?

@usurai
Copy link
Contributor

usurai commented May 11, 2022

@usurai Would you share a link to the PR?

It's #1466
Thanks!

@jijufb
Copy link
Contributor

jijufb commented May 11, 2022

HI usurai, can you send your email address to provide access to slack channel?

@usurai
Copy link
Contributor

usurai commented May 11, 2022

HI usurai, can you send your email address to provide access to slack channel?

Hi @jijufb, my email is crowdwei@gmail.com. Thanks!

@jijufb
Copy link
Contributor

jijufb commented May 11, 2022

Invitation has send to your email address to access slack channels.

@usurai
Copy link
Contributor

usurai commented May 11, 2022

I've got in, thanks for your help!

Arty-Maly pushed a commit to Arty-Maly/velox that referenced this issue May 13, 2022
@usurai @Arty-Maly
More types in HivePartitionFunction (facebookincubator#1466)
2a1da9d 
Summary:
Add support for more types in `HivePartitionFunction`:
- `TINYINT`
- `SMALLINT`
- `INTEGER`
- `REAL`
- `DOUBLE`
- `VARBINARY`
- `TIMESTAMP`
- `DATE`

Fixes facebookincubator#327

Pull Request resolved: facebookincubator#1466

Reviewed By: Yuhta

Differential Revision: D36345326

Pulled By: mbasmanova

fbshipit-source-id: a32b76e8608cac3a8044ef0d468a2c479f62037d
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this issue Jun 21, 2022
@usurai
More types in HivePartitionFunction (facebookincubator#1466)
02f61c1 
Summary:
Add support for more types in `HivePartitionFunction`:
- `TINYINT`
- `SMALLINT`
- `INTEGER`
- `REAL`
- `DOUBLE`
- `VARBINARY`
- `TIMESTAMP`
- `DATE`

Fixes facebookincubator#327

Pull Request resolved: facebookincubator#1466

Reviewed By: Yuhta

Differential Revision: D36345326

Pulled By: mbasmanova

fbshipit-source-id: a32b76e8608cac3a8044ef0d468a2c479f62037d
shiyu-bytedance pushed a commit to shiyu-bytedance/velox-1 that referenced this issue Aug 18, 2022
@usurai
More types in HivePartitionFunction (facebookincubator#1466)
53b4280 
Summary:
Add support for more types in `HivePartitionFunction`:
- `TINYINT`
- `SMALLINT`
- `INTEGER`
- `REAL`
- `DOUBLE`
- `VARBINARY`
- `TIMESTAMP`
- `DATE`

Fixes facebookincubator#327

Pull Request resolved: facebookincubator#1466

Reviewed By: Yuhta

Differential Revision: D36345326

Pulled By: mbasmanova

fbshipit-source-id: a32b76e8608cac3a8044ef0d468a2c479f62037d
rui-mo pushed a commit to rui-mo/velox that referenced this issue Mar 17, 2023
@marin-ma
[OPPRO-224] Fix arrow backend table scan result mismatch (facebookinc…
66f2c27 
…ubator#327)

* remove offset

* fix coredump

* remove example
rui-mo added a commit to rui-mo/velox that referenced this issue Jun 28, 2023
@rui-mo
Add function name mapping from equal_null_safe to equalnullsafe (face…
bb35ed6 
…bookincubator#327)
zhli1142015 pushed a commit to zhli1142015/velox that referenced this issue Jul 3, 2023
@rui-mo @zhejiangxiaomai
Add function name mapping from equal_null_safe to equalnullsafe (face…
d081d2e 
…bookincubator#327)
Yohahaha pushed a commit to Yohahaha/velox that referenced this issue Jul 4, 2023
@rui-mo @zhejiangxiaomai
Add function name mapping from equal_null_safe to equalnullsafe (face…
2bf58aa 
…bookincubator#327)
chenxu14 pushed a commit to chenxu14/velox that referenced this issue Jul 5, 2023
@rui-mo @zhejiangxiaomai
Add function name mapping from equal_null_safe to equalnullsafe (face…
07d191d 
…bookincubator#327)
PHILO-HE pushed a commit to PHILO-HE/velox that referenced this issue Jul 17, 2023
@rui-mo @zhejiangxiaomai
Add function name mapping from equal_null_safe to equalnullsafe (face…
dc5f535 
…bookincubator#327)
rui-mo added a commit to rui-mo/velox that referenced this issue Jul 21, 2023
@rui-mo
Add function name mapping from equal_null_safe to equalnullsafe (face…
ad16ff3 
…bookincubator#327)
rui-mo added a commit to rui-mo/velox that referenced this issue Jul 24, 2023
@rui-mo
Add function name mapping from equal_null_safe to equalnullsafe (face…
83e0e31 
…bookincubator#327)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More types in HivePartitionFunction usurai/velox
4 participants
@usurai @mbasmanova @thenotoriouscodefather @jijufb