Fail to build with with compilation error on Folly

[viirya]

I tried to build this on Mac OS, but saw the error as follows:

/usr/local/include/folly/Conv.h:744:41: error: no matching function for call to 'estimateSpaceNeeded'
  return estimateSpaceToReserve(sofar + estimateSpaceNeeded(v), vs...);                                                                                                                        
                                        ^~~~~~~~~~~~~~~~~~~

I looked at Conv.h quickly, there are some candidate templates. But based on the message of compiler, seems these templates are not suitable for unsigned __int128 so the compiler cannot find a matching function of estimateSpaceNeeded.

[viirya]

This can be fixed by Homebrew/homebrew-core#86451

[pedroerp]

I remember seeing this problem in Ubuntu as well, so I had to add this flag:

https://github.com/facebookincubator/velox/blob/main/scripts/setup-ubuntu.sh#L73

does this help in your case as well (adding the flag to setup-macos.sh)?

[viirya]

Yes, I added the flag to homebrew folly Formula to fix it. You can see the above PR.

For Velox, it is harder for us to directly contribute for now, so I leave setup-macos.sh to others who can simply add it.

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.