Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DateTimeFormatter::parse to return velox::Expected #9915

Closed
mbasmanova opened this issue May 23, 2024 · 3 comments
Closed

Refactor DateTimeFormatter::parse to return velox::Expected #9915

mbasmanova opened this issue May 23, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@mbasmanova
Copy link
Contributor

Description

We have recently introduced velox::Expected (#9858) to use in non-void no-throw APIs. It would be nice to refactor DateTimeFormatter::parse to use that.

CC: @rui-mo @kgpai @pedroerp @Yuhta @PHILO-HE
@mbasmanova mbasmanova added the enhancement New feature or request label May 23, 2024
@wypb
Copy link
Contributor

wypb commented Jun 11, 2024

HI @mbasmanova Is anyone doing this? If not, I can refactor it.

@mbasmanova
Copy link
Contributor Author

@wypb I don't think anyone is working on this. Feel free to pick it up. Thanks.

@wypb wypb mentioned this issue Jun 12, 2024
Closed
@wypb
Copy link
Contributor

wypb commented Jun 12, 2024

Hi @mbasmanova Masha, I have submitted a PR, please help me review it when you have a chance. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor DateTimeFormatter::parse to return velox::Expected wypb/velox
2 participants
@wypb @mbasmanova