Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix array_intersect/except for dictionary encoded or null input #2959

Closed

Conversation

mbasmanova
Copy link
Contributor

@mbasmanova mbasmanova commented Oct 26, 2022

The array_intersect and array_expect functions didn't work properly if invoked
for a subset of rows, e.g when input was dictionary encoded or contained nulls.

Fixes #2794

@netlify
Copy link

netlify bot commented Oct 26, 2022

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 63ddb1e
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/635940ee5f857c00081b03fd

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 26, 2022
@facebook-github-bot
Copy link
Contributor

@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

…bookincubator#2959)

Summary:
The array_intersect and array_expect functions didn't work properly if invoked
for a subset of rows, e.g when input was dictionary encoded or contained nulls.

Fixes facebookincubator#2794

Pull Request resolved: facebookincubator#2959

Reviewed By: Yuhta

Differential Revision: D40706898

Pulled By: mbasmanova

fbshipit-source-id: 7bbf70c264d485be64d612cef70071d8189d42e0
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40706898

Copy link
Collaborator

@aditi-pandit aditi-pandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Masha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unmatched result of arrays_overlap(array_intersect(...), ...)
4 participants