Fix glog deps, add some missing dependencies
#500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
My original fix (D30134167) seems to have been partially reverted; this
PR just re-applies the core changes along with some minor style fixes to
the CMake files.
The build was failing sometimes because velox_dwrf_int_decoder_benchmark
was missing a dependency on velox_dwio_dwrf_common, which transitively
depended on the proto headers. This would sometimes result in this
target being built before the proto headers were generated.
`include_directories(${CMAKE_BINARY_DIR})` at the top of the CMake file
in this directory was masking this. Now we should once again get
deterministic failures if a dependency is missing.
|
@funrollloops has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@funrollloops has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@funrollloops merged this pull request in 2990354. |
|
@funrollloops by apply this path, cmake failed with followiing message: My Os is ubuntu 20.04, and setup_ubuntu.sh is alreay called, however it works in My macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bunch of bugs in the dependency graph when I tried to build with glog in a non-standard location. This PR uses find_package(glog) instead of find_library, so that we also get the correct include path.
A few libraries didn't declare their dependencies (or any dependencies, really) and so also failed to build because they didn't get the necessary include paths added.
Includes #499 and #387.