Add support for S3 FileSystem compatible schemes 'cos' and 'cosn' #5619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
majetideepak
approved these changes
Jul 12, 2023
|
@mbasmanova could you help me review this pull request. |
mbasmanova
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
@wypb Thanks.
@majetideepak Deepak, do we have documentation for S3 adapter? If not, would it be possible to add?
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@mbasmanova merged this pull request in 19d0392. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
|
@mbasmanova I will prioritize #2861. Will have something by early next week. It is long over due. |
|
Thank you, Deepak. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tencent COS is a famous object storage system provided by Tencent Corp. From this document COS offers AWS S3-compatible APIs, and we can use the APIs of S3 SDK to access files in COS. This pull request introduce acceptance of
cos://andcosn://prefixes as supported and compatibleS3implementations.Usage
With this pull request, We set the following parameters in the
hive.propertiesfile to access cos