Adds checks for verifying internal state of a vector #5885
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
bikramSingh91
force-pushed
the
addVectorIntegrityChecks
branch
2 times, most recently
from
b60f3b1
to
8f5a7f6
Compare
|
@bikramSingh91 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
bikramSingh91
force-pushed
the
addVectorIntegrityChecks
branch
from
8f5a7f6
to
1d0c5f2
Compare
|
@bikramSingh91 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
bikramSingh91
force-pushed
the
addVectorIntegrityChecks
branch
2 times, most recently
from
fa651ed
to
cea7956
Compare
|
@bikramSingh91 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Yuhta
reviewed
Aug 1, 2023
bikramSingh91
force-pushed
the
addVectorIntegrityChecks
branch
from
cea7956
to
ee19057
Compare
bikramSingh91
force-pushed
the
addVectorIntegrityChecks
branch
from
ee19057
to
10b8165
Compare
|
@bikramSingh91 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
bikramSingh91
force-pushed
the
addVectorIntegrityChecks
branch
from
10b8165
to
2e7b0fb
Compare
|
@bikramSingh91 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Yuhta
reviewed
Aug 2, 2023
bikramSingh91
force-pushed
the
addVectorIntegrityChecks
branch
from
2e7b0fb
to
ead376f
Compare
|
@bikramSingh91 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Yuhta
reviewed
Aug 4, 2023
This change adds thorough checks for each vector type, including its children vectors. These checks verify the validity of buffer sizes and their values (if applicable), such as nulls, values, and indices, offsets, etc. Currently, its only used in debug builds on the result of expressions and the objective is to catch these issues especially in the expression fuzzer. These checks help clarify expected states and enforce them, improving overall vector reliability. This check also found a bug in Combinations(Array<>) udf which is fixed as a part of this change. Test Plan: Ran fuzzer for 1 hour
bikramSingh91
force-pushed
the
addVectorIntegrityChecks
branch
from
ead376f
to
ae47c87
Compare
|
@bikramSingh91 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Yuhta
approved these changes
Aug 8, 2023
|
@bikramSingh91 merged this pull request in 8ce030f. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
unigof
pushed a commit
to unigof/velox
that referenced
this pull request
Aug 18, 2023
…or#5885) Summary: This change adds thorough checks for each vector type, including its children vectors. These checks verify the validity of buffer sizes and their values (if applicable), such as nulls, values, and indices, offsets, etc. Currently, its only used in debug builds on the result of expressions and the objective is to catch these issues especially in the expression fuzzer. These checks help clarify expected states and enforce them, improving overall vector reliability. This check also found a bug in Combinations(Array<>) udf which is fixed as a part of this change. Pull Request resolved: facebookincubator#5885 Test Plan: Ran fuzzer for 1 hour Reviewed By: Yuhta Differential Revision: D47856464 Pulled By: bikramSingh91 fbshipit-source-id: 03dc82137eb8c2691561af041053bb8cb6e4bc99
bikramSingh91
pushed a commit
to bikramSingh91/velox
that referenced
this pull request
Aug 29, 2023
Summary: This fixes a bug where the string buffers were not acquired from the input to the UDF. Caught by facebookincubator#5885 Differential Revision: D48800126 fbshipit-source-id: a6138be8393985c4da3324a50a57c880484b4180
bikramSingh91
pushed a commit
to bikramSingh91/velox
that referenced
this pull request
Aug 30, 2023
Summary: Pull Request resolved: facebookincubator#6336 This fixes a bug where the string buffers were not acquired from the input to the UDF. Caught by facebookincubator#5885 Differential Revision: D48800126 fbshipit-source-id: 325b0c78b18843ac0a15688e68a2011080f42805
bikramSingh91
pushed a commit
to bikramSingh91/velox
that referenced
this pull request
Aug 30, 2023
Summary: Pull Request resolved: facebookincubator#6336 This fixes a bug where the string buffers were not acquired from the input to the UDF. Caught by facebookincubator#5885 Differential Revision: D48800126 fbshipit-source-id: 1a57dabcb72120ba99d2cded702075e9afbbf1d1
bikramSingh91
pushed a commit
to bikramSingh91/velox
that referenced
this pull request
Aug 30, 2023
Summary: Pull Request resolved: facebookincubator#6336 This fixes a bug where the string buffers were not acquired from the input to the UDF. Caught by facebookincubator#5885 Differential Revision: D48800126 fbshipit-source-id: a0d631f68bb388c82cc8a3bc5928394ca3614789
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
Summary: Pull Request resolved: facebookincubator#6336 This fixes a bug where the string buffers were not acquired from the input to the UDF. Caught by facebookincubator#5885 Reviewed By: kgpai Differential Revision: D48800126 fbshipit-source-id: 4f070cabfa9c2c40c5b8ca0b0444afebb7922d7e
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
Summary: Pull Request resolved: facebookincubator#6336 This fixes a bug where the string buffers were not acquired from the input to the UDF. Caught by facebookincubator#5885 Reviewed By: kgpai Differential Revision: D48800126 fbshipit-source-id: 4f070cabfa9c2c40c5b8ca0b0444afebb7922d7e
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
Summary: Pull Request resolved: facebookincubator#6336 This fixes a bug where the string buffers were not acquired from the input to the UDF. Caught by facebookincubator#5885 Reviewed By: kgpai Differential Revision: D48800126 fbshipit-source-id: 4f070cabfa9c2c40c5b8ca0b0444afebb7922d7e
ericyuliu
pushed a commit
to ericyuliu/velox
that referenced
this pull request
Oct 12, 2023
…or#5885) Summary: This change adds thorough checks for each vector type, including its children vectors. These checks verify the validity of buffer sizes and their values (if applicable), such as nulls, values, and indices, offsets, etc. Currently, its only used in debug builds on the result of expressions and the objective is to catch these issues especially in the expression fuzzer. These checks help clarify expected states and enforce them, improving overall vector reliability. This check also found a bug in Combinations(Array<>) udf which is fixed as a part of this change. Pull Request resolved: facebookincubator#5885 Test Plan: Ran fuzzer for 1 hour Reviewed By: Yuhta Differential Revision: D47856464 Pulled By: bikramSingh91 fbshipit-source-id: 03dc82137eb8c2691561af041053bb8cb6e4bc99
ericyuliu
pushed a commit
to ericyuliu/velox
that referenced
this pull request
Oct 12, 2023
Summary: Pull Request resolved: facebookincubator#6336 This fixes a bug where the string buffers were not acquired from the input to the UDF. Caught by facebookincubator#5885 Reviewed By: kgpai Differential Revision: D48800126 fbshipit-source-id: 4f070cabfa9c2c40c5b8ca0b0444afebb7922d7e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds thorough checks for each vector type, including its
children vectors. These checks verify the validity of buffer sizes
and their values (if applicable), such as nulls, values, and indices,
offsets, etc. Currently, its only used in debug builds on the result
of expressions and the objective is to catch these issues especially
in the expression fuzzer. These checks help clarify expected states
and enforce them, improving overall vector reliability.
This check also found a bug in Combinations(Array<>) udf which is
fixed as a part of this change.
Test Plan:
Ran fuzzer for 1 hour