Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support longer fuzzer runs when changing sensitive files. #6009

Closed
wants to merge 1 commit into from

Conversation

kgpai
Copy link
Contributor

@kgpai kgpai commented Aug 5, 2023

Creates dynamic config that runs a longer fuzzer job when changes are made to sensitive files. This was previously reverted because CCI couldnt run scheduled jobs with dynamic config. Now that scheduled jobs have been moved , we can re-enable this.

When we detect changes to sensitive files (say some file in velox/exec/...) then the presto fuzzer job is run for an hour during the PR.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 5, 2023
@netlify
Copy link

netlify bot commented Aug 5, 2023

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit b5303f8
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/64d1395b32de7a0008d53262

@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kgpai merged this pull request in 4cd2a81.

@conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit 4cd2a810.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

unigof pushed a commit to unigof/velox that referenced this pull request Aug 18, 2023
…cubator#6009)

Summary:
Creates dynamic config that runs a longer fuzzer job when changes are made to sensitive files. This was previously reverted because CCI couldnt run scheduled jobs with dynamic config. Now that scheduled jobs have been moved , we can re-enable this.

When we detect changes to sensitive files (say some file in velox/exec/...) then the presto fuzzer job is run for an hour during the PR.

Pull Request resolved: facebookincubator#6009

Reviewed By: xiaoxmeng

Differential Revision: D48087776

Pulled By: kgpai

fbshipit-source-id: f30114af4237e21d500570c2824b5b998f581a99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants