Add spilling performance benchmark #6071
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xiaoxmeng
force-pushed
the
spill
branch
20 times, most recently
from
0d4b574
to
3cacb87
Compare
xiaoxmeng
changed the title
xiaoxmeng
force-pushed
the
spill
branch
3 times, most recently
from
f64dd53
to
6141045
Compare
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was exported from Phabricator. Differential Revision: D48217707 |
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Aug 14, 2023
Summary: - Add more spill stats to break down the spill write path and collect both per-query and global (aggregated stats across all queries) stats. The per-query stats is reported through task runtime stats and the latter are collected in a global stats (shared by thread id) - Refactor spiller internal stats collection mechanism. - Add hash probe spill stats collection - Change hash build to report stats at operator level - Add spill input performance benchmark Followup will report the global stats through stats (like ODS in Meta) mechanism by Prestissimo Pull Request resolved: facebookincubator#6071 Differential Revision: D48217707 Pulled By: xiaoxmeng fbshipit-source-id: 4364ed4e3847e9fcfd381e2221df02afe8aa247a
Summary: - Add more spill stats to break down the spill write path and collect both per-query and global (aggregated stats across all queries) stats. The per-query stats is reported through task runtime stats and the latter are collected in a global stats (shared by thread id) - Refactor spiller internal stats collection mechanism. - Add hash probe spill stats collection - Change hash build to report stats at operator level - Add spill input performance benchmark Followup will report the global stats through stats (like ODS in Meta) mechanism by Prestissimo Pull Request resolved: facebookincubator#6071 Reviewed By: oerling Differential Revision: D48217707 Pulled By: xiaoxmeng fbshipit-source-id: 9853618c85d3801c2801c8a60a1d68d0d4afdb77
|
This pull request was exported from Phabricator. Differential Revision: D48217707 |
|
@xiaoxmeng merged this pull request in f97c954. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
unigof
pushed a commit
to unigof/velox
that referenced
this pull request
Aug 18, 2023
Summary: - Add more spill stats to break down the spill write path and collect both per-query and global (aggregated stats across all queries) stats. The per-query stats is reported through task runtime stats and the latter are collected in a global stats (shared by thread id) - Refactor spiller internal stats collection mechanism. - Add hash probe spill stats collection - Change hash build to report stats at operator level - Add spill input performance benchmark Followup will report the global stats through stats (like ODS in Meta) mechanism by Prestissimo Pull Request resolved: facebookincubator#6071 Reviewed By: oerling Differential Revision: D48217707 Pulled By: xiaoxmeng fbshipit-source-id: c40b8075d444ea9711d0676254fc6f6f2b0d44ec
ericyuliu
pushed a commit
to ericyuliu/velox
that referenced
this pull request
Oct 12, 2023
Summary: - Add more spill stats to break down the spill write path and collect both per-query and global (aggregated stats across all queries) stats. The per-query stats is reported through task runtime stats and the latter are collected in a global stats (shared by thread id) - Refactor spiller internal stats collection mechanism. - Add hash probe spill stats collection - Change hash build to report stats at operator level - Add spill input performance benchmark Followup will report the global stats through stats (like ODS in Meta) mechanism by Prestissimo Pull Request resolved: facebookincubator#6071 Reviewed By: oerling Differential Revision: D48217707 Pulled By: xiaoxmeng fbshipit-source-id: c40b8075d444ea9711d0676254fc6f6f2b0d44ec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
both per-query and global (aggregated stats across all queries) stats.
The per-query stats is reported through task runtime stats and the
latter are collected in a global stats (shared by thread id)
Followup will report the global stats through stats (like ODS in Meta)
mechanism by Prestissimo