Fix handling of exceptions in try_cast from Json #6116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: try_cast from Json to complex types used to throw when there are exceptions during casting from the first row. The reason is that in this situation, castFromJson() calls add_item() of the top-level complex-type writer before its child generic writer is casted. VectorWriter<Generic<T>> doesn't allow this use case before this fix. Differential Revision: D48370227 fbshipit-source-id: bfd4b769758aa86101efd0c0e0cae7b762e6df8b
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D48370227 |
|
This pull request has been merged in f4dfad4. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
unigof
pushed a commit
to unigof/velox
that referenced
this pull request
Aug 18, 2023
) Summary: Pull Request resolved: facebookincubator#6116 try_cast from Json to complex types used to throw when there are exceptions during casting from the first row. The reason is that in this situation, castFromJson() calls add_item() of the top-level complex-type writer before its child generic writer is casted. VectorWriter<Generic<T>> doesn't allow this use case before this fix. Reviewed By: laithsakka Differential Revision: D48370227 fbshipit-source-id: e0cb8d3a04097c14f0687733f33cce66854dc979
ericyuliu
pushed a commit
to ericyuliu/velox
that referenced
this pull request
Oct 12, 2023
) Summary: Pull Request resolved: facebookincubator#6116 try_cast from Json to complex types used to throw when there are exceptions during casting from the first row. The reason is that in this situation, castFromJson() calls add_item() of the top-level complex-type writer before its child generic writer is casted. VectorWriter<Generic<T>> doesn't allow this use case before this fix. Reviewed By: laithsakka Differential Revision: D48370227 fbshipit-source-id: e0cb8d3a04097c14f0687733f33cce66854dc979
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: try_cast from Json to complex types used to throw when there are exceptions during casting from the first row. The reason is that in this situation, castFromJson() calls add_item() of the top-level complex-type writer before its child generic writer is casted. VectorWriter<Generic> doesn't allow this use case before this fix.
Differential Revision: D48370227