Fix: support unknown in map_from_entries function #6353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48837795 |
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D48837795 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Aug 30, 2023
…6353) Summary: Pull Request resolved: facebookincubator#6353 presto support `` try (select MAP_FROM_ENTRIES(ARRAY[Row(null, null)])) `` and `` try (select MAP_FROM_ENTRIES(ARRAY[null])) `` Differential Revision: D48837795 fbshipit-source-id: 2d9cc9644b3b917133efed9130a7ff9e085848bd
laithsakka
force-pushed
the
export-D48837795
branch
from
818ffe0
to
7cb85f1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48837795 |
laithsakka
force-pushed
the
export-D48837795
branch
from
7cb85f1
to
6a8e597
Compare
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Aug 31, 2023
…6353) Summary: Pull Request resolved: facebookincubator#6353 presto support `` try (select MAP_FROM_ENTRIES(ARRAY[Row(null, null)])) `` and `` try (select MAP_FROM_ENTRIES(ARRAY[null])) `` Differential Revision: D48837795 fbshipit-source-id: b581359fbf96684fe85f5fe00ac12e3ce15d5ab3
|
This pull request was exported from Phabricator. Differential Revision: D48837795 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Aug 31, 2023
…6353) Summary: Pull Request resolved: facebookincubator#6353 presto support `` try (select MAP_FROM_ENTRIES(ARRAY[Row(null, null)])) `` and `` try (select MAP_FROM_ENTRIES(ARRAY[null])) `` Differential Revision: D48837795 fbshipit-source-id: cf5a3c8fcf9ed3f55764789ed712febb15a2349a
laithsakka
force-pushed
the
export-D48837795
branch
from
6a8e597
to
34bd6f7
Compare
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Sep 14, 2023
…6353) Summary: presto support `` try (select MAP_FROM_ENTRIES(ARRAY[Row(null, null)])) `` and `` try (select MAP_FROM_ENTRIES(ARRAY[null])) `` Differential Revision: D48837795
laithsakka
force-pushed
the
export-D48837795
branch
from
34bd6f7
to
266cf26
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48837795 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Sep 14, 2023
…6353) Summary: presto support `` try (select MAP_FROM_ENTRIES(ARRAY[Row(null, null)])) `` and `` try (select MAP_FROM_ENTRIES(ARRAY[null])) `` Differential Revision: D48837795
laithsakka
force-pushed
the
export-D48837795
branch
from
266cf26
to
32e504e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48837795 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Sep 14, 2023
…6353) Summary: presto support `` try (select MAP_FROM_ENTRIES(ARRAY[Row(null, null)])) `` and `` try (select MAP_FROM_ENTRIES(ARRAY[null])) `` Differential Revision: D48837795
laithsakka
force-pushed
the
export-D48837795
branch
from
32e504e
to
291288f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48837795 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Sep 14, 2023
…6353) Summary: presto support `` try (select MAP_FROM_ENTRIES(ARRAY[Row(null, null)])) `` and `` try (select MAP_FROM_ENTRIES(ARRAY[null])) `` Differential Revision: D48837795
laithsakka
force-pushed
the
export-D48837795
branch
from
291288f
to
8a1614b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48837795 |
mbasmanova
approved these changes
Sep 14, 2023
| rows.end(), | ||
| sizes, | ||
| offsets, | ||
| BaseVector::create(UNKNOWN(), 0, context.pool()), |
There was a problem hiding this comment.
You can pass nullptr here
|
This pull request was exported from Phabricator. Differential Revision: D48837795 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Sep 14, 2023
…6353) Summary: Pull Request resolved: facebookincubator#6353 presto support `` try (select MAP_FROM_ENTRIES(ARRAY[Row(null, null)])) `` and `` try (select MAP_FROM_ENTRIES(ARRAY[null])) `` Reviewed By: mbasmanova Differential Revision: D48837795 fbshipit-source-id: 1b78a2ed4fce651f644f35f399f0e24574149f1d
laithsakka
force-pushed
the
export-D48837795
branch
from
8a1614b
to
7cc08a9
Compare
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Sep 15, 2023
…6353) Summary: presto support `` try (select MAP_FROM_ENTRIES(ARRAY[Row(null, null)])) `` and `` try (select MAP_FROM_ENTRIES(ARRAY[null])) `` Reviewed By: mbasmanova Differential Revision: D48837795
laithsakka
force-pushed
the
export-D48837795
branch
from
7cc08a9
to
a12b3a9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48837795 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Sep 15, 2023
…6353) Summary: presto support `` try (select MAP_FROM_ENTRIES(ARRAY[Row(null, null)])) `` and `` try (select MAP_FROM_ENTRIES(ARRAY[null])) `` Reviewed By: mbasmanova Differential Revision: D48837795
laithsakka
force-pushed
the
export-D48837795
branch
from
a12b3a9
to
f3b1172
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48837795 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Sep 15, 2023
…6353) Summary: presto support `` try (select MAP_FROM_ENTRIES(ARRAY[Row(null, null)])) `` and `` try (select MAP_FROM_ENTRIES(ARRAY[null])) `` Reviewed By: mbasmanova Differential Revision: D48837795
laithsakka
force-pushed
the
export-D48837795
branch
from
f3b1172
to
b7102cc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48837795 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Sep 15, 2023
…6353) Summary: presto support `` try (select MAP_FROM_ENTRIES(ARRAY[Row(null, null)])) `` and `` try (select MAP_FROM_ENTRIES(ARRAY[null])) `` Reviewed By: mbasmanova Differential Revision: D48837795
laithsakka
force-pushed
the
export-D48837795
branch
from
b7102cc
to
a5daed9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48837795 |
…6353) Summary: presto support `` try (select MAP_FROM_ENTRIES(ARRAY[Row(null, null)])) `` and `` try (select MAP_FROM_ENTRIES(ARRAY[null])) `` Reviewed By: mbasmanova Differential Revision: D48837795
laithsakka
force-pushed
the
export-D48837795
branch
from
a5daed9
to
5602309
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48837795 |
|
This pull request has been merged in a3c4aac. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
…6353) Summary: Pull Request resolved: facebookincubator#6353 presto support `` try (select MAP_FROM_ENTRIES(ARRAY[Row(null, null)])) `` and `` try (select MAP_FROM_ENTRIES(ARRAY[null])) `` Reviewed By: mbasmanova Differential Revision: D48837795 fbshipit-source-id: 372097d333f9f90a5de4507c584d29388dd18d95
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
…6353) Summary: Pull Request resolved: facebookincubator#6353 presto support `` try (select MAP_FROM_ENTRIES(ARRAY[Row(null, null)])) `` and `` try (select MAP_FROM_ENTRIES(ARRAY[null])) `` Reviewed By: mbasmanova Differential Revision: D48837795 fbshipit-source-id: 372097d333f9f90a5de4507c584d29388dd18d95
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
…6353) Summary: Pull Request resolved: facebookincubator#6353 presto support `` try (select MAP_FROM_ENTRIES(ARRAY[Row(null, null)])) `` and `` try (select MAP_FROM_ENTRIES(ARRAY[null])) `` Reviewed By: mbasmanova Differential Revision: D48837795 fbshipit-source-id: 372097d333f9f90a5de4507c584d29388dd18d95
ericyuliu
pushed a commit
to ericyuliu/velox
that referenced
this pull request
Oct 12, 2023
…6353) Summary: Pull Request resolved: facebookincubator#6353 presto support `` try (select MAP_FROM_ENTRIES(ARRAY[Row(null, null)])) `` and `` try (select MAP_FROM_ENTRIES(ARRAY[null])) `` Reviewed By: mbasmanova Differential Revision: D48837795 fbshipit-source-id: 372097d333f9f90a5de4507c584d29388dd18d95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
presto support
try (select MAP_FROM_ENTRIES(ARRAY[Row(null, null)]))and
try (select MAP_FROM_ENTRIES(ARRAY[null]))Differential Revision: D48837795