Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TTL for AsyncDataCache and SsdCache #6412

Closed
wants to merge 1 commit into from

Conversation

gggrace14
Copy link
Contributor

@gggrace14 gggrace14 commented Sep 5, 2023

Support cache TTL for AsyncDataCache and SsdCache. CacheTTLController
derives a list of files with age greater than the given ttl in seconds, and
remove cache entries loaded from the aged out files. File age uses
the raw file open time as the start time, which is tracked by
CacheTTLController.

@netlify
Copy link

netlify bot commented Sep 5, 2023

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 319840d
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/658380537358fc00099c66fc

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 5, 2023
@gggrace14 gggrace14 marked this pull request as ready for review September 6, 2023 19:27
@facebook-github-bot
Copy link
Contributor

@gggrace14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@gggrace14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link

stale bot commented Dec 10, 2023

This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions!

@facebook-github-bot
Copy link
Contributor

@gggrace14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@gggrace14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@gggrace14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@gggrace14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@gggrace14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Support cache TTL for AsyncDataCache and SsdCache. CacheTTLController
derives a list of files with age greater than the given ttl in seconds, and
remove cache entries loaded from the aged out files. File age uses
the raw file open time as the start time, which is tracked by
CacheTTLController.
@facebook-github-bot
Copy link
Contributor

@gggrace14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@gggrace14 merged this pull request in 5e0fd09.

@gggrace14 gggrace14 deleted the ttl branch December 21, 2023 03:15
Copy link

Conbench analyzed the 1 benchmark run on commit 5e0fd098.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants