-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support TTL for AsyncDataCache and SsdCache #6412
Conversation
✅ Deploy Preview for meta-velox canceled.
|
0bdbb56
to
6fbd10a
Compare
2335aed
to
40fd4c1
Compare
@gggrace14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
d3d2562
to
dd650d4
Compare
@gggrace14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions! |
f8f83bc
to
1459696
Compare
@gggrace14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
c193994
to
dcf711b
Compare
@gggrace14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
61bf03e
to
67feca3
Compare
@gggrace14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
145119c
to
8cd3e0f
Compare
f78caff
to
c2db9a1
Compare
@gggrace14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@gggrace14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Support cache TTL for AsyncDataCache and SsdCache. CacheTTLController derives a list of files with age greater than the given ttl in seconds, and remove cache entries loaded from the aged out files. File age uses the raw file open time as the start time, which is tracked by CacheTTLController.
@gggrace14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@gggrace14 merged this pull request in 5e0fd09. |
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Support cache TTL for AsyncDataCache and SsdCache. CacheTTLController
derives a list of files with age greater than the given ttl in seconds, and
remove cache entries loaded from the aged out files. File age uses
the raw file open time as the start time, which is tracked by
CacheTTLController.