Fix handling null string in json_extract() #6439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SIMDJsonExtractFunction` returned null directly when there was only one value mapped to the json path and it was null. However, in Presto, the function returns null string instead of null value for this case. Fixes facebookincubator#6437
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
mbasmanova
reviewed
Sep 6, 2023
| @@ -549,7 +549,7 @@ TEST_F(JsonFunctionsTest, jsonExtract) { | |||
| EXPECT_EQ( | |||
| "3", jsonExtract("{\"x\": {\"a\" : 1, \"b\" : [2, 3]} }", "$.x.b[1]")); | |||
| EXPECT_EQ("2", jsonExtract("[1,2,3]", "$[1]")); | |||
| EXPECT_EQ(std::nullopt, jsonExtract("[1,null,3]", "$[1]")); | |||
| EXPECT_EQ("null", jsonExtract("[1,null,3]", "$[1]")); | |||
There was a problem hiding this comment.
Here is what I see in Presto,
presto:di> select json_extract('[1,null,3]', '#[1]');
_col0
-------
NULL
(1 row)
Do you see something different?
There was a problem hiding this comment.
I run test case of testJsonExtract() in TestJsonExtractFunctions.java of Presto.
// pass
assertFunction(format("JSON_EXTRACT('%s', '%s')", "[1,null,3]", "$[1]"), JSON, "null");
// fail
assertFunction(format("JSON_EXTRACT('%s', '%s')", "[1,null,3]", "$[1]"), JSON, null);
There was a problem hiding this comment.
I see. Looks like I had a typo above:
presto:di> select json_extract('[1,null,3]', '$[1]');
_col0
-------
null
(1 row)
mbasmanova
approved these changes
Sep 6, 2023
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@mbasmanova merged this pull request in 524591e. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
Summary: `SIMDJsonExtractFunction` returned null directly when there was only one value mapped to the json path and it was null. However, in Presto, the function returns null string instead of null value for this case. Fixes facebookincubator#6437 Pull Request resolved: facebookincubator#6439 Reviewed By: Yuhta Differential Revision: D49009808 Pulled By: mbasmanova fbshipit-source-id: c98e8fbce8d420ebed06403a4b9d3beb5ab8ee47
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
Summary: `SIMDJsonExtractFunction` returned null directly when there was only one value mapped to the json path and it was null. However, in Presto, the function returns null string instead of null value for this case. Fixes facebookincubator#6437 Pull Request resolved: facebookincubator#6439 Reviewed By: Yuhta Differential Revision: D49009808 Pulled By: mbasmanova fbshipit-source-id: c98e8fbce8d420ebed06403a4b9d3beb5ab8ee47
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
Summary: `SIMDJsonExtractFunction` returned null directly when there was only one value mapped to the json path and it was null. However, in Presto, the function returns null string instead of null value for this case. Fixes facebookincubator#6437 Pull Request resolved: facebookincubator#6439 Reviewed By: Yuhta Differential Revision: D49009808 Pulled By: mbasmanova fbshipit-source-id: c98e8fbce8d420ebed06403a4b9d3beb5ab8ee47
ericyuliu
pushed a commit
to ericyuliu/velox
that referenced
this pull request
Oct 12, 2023
Summary: `SIMDJsonExtractFunction` returned null directly when there was only one value mapped to the json path and it was null. However, in Presto, the function returns null string instead of null value for this case. Fixes facebookincubator#6437 Pull Request resolved: facebookincubator#6439 Reviewed By: Yuhta Differential Revision: D49009808 Pulled By: mbasmanova fbshipit-source-id: c98e8fbce8d420ebed06403a4b9d3beb5ab8ee47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIMDJsonExtractFunctionreturned null directly when there was only one value mapped to the json path and it was null. However, in Presto, the function returns null string instead of null value for this case.Fixes #6437