Add BaseVector::containsNullAt API #6515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
mbasmanova
force-pushed
the
contains-null-at
branch
from
53977dd
to
657e7f5
Compare
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
pedroerp
approved these changes
Sep 11, 2023
| @@ -80,6 +80,19 @@ class DictionaryVector : public SimpleVector<T> { | |||
|
|
|||
| bool isNullAt(vector_size_t idx) const override; | |||
|
|
|||
| bool containsNullAt(vector_size_t idx) const override { | |||
| if constexpr (std::is_same_v<T, ComplexType>) { | |||
There was a problem hiding this comment.
not sure I understand this part. In which cases we have dictionaries with ComplexType and when we don't?
There was a problem hiding this comment.
A dictionary vector can wrap a primitive type vector or a complex type vector. In the former case T will be primitive type. In the latter case T will be ComplexType.
| EXPECT_TRUE(data->containsNullAt(1)); | ||
| EXPECT_TRUE(data->containsNullAt(2)); | ||
| EXPECT_TRUE(data->containsNullAt(3)); | ||
| EXPECT_FALSE(data->containsNullAt(4)); |
There was a problem hiding this comment.
Should we also have a test for nested containers?
There was a problem hiding this comment.
Sure. Let me add some.
There was a problem hiding this comment.
@pedroerp Added.
mbasmanova
force-pushed
the
contains-null-at
branch
from
657e7f5
to
7e3e957
Compare
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@mbasmanova merged this pull request in fb71ab2. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
Summary: In Presto, x IN (a, b, c) evaluated on complex types returns NULL if x doesn't match a, b, c, but contains null or any of a, b, c contains null. Depends on #6515 Pull Request resolved: #6513 Reviewed By: pedroerp Differential Revision: D49155902 Pulled By: mbasmanova fbshipit-source-id: 5149122a9e888d2831d9462167fd3ac33ce04db8
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
Summary: BaseVector::containsNullAt(idx) returns true if value at the specified index is null or contains null. Primitive type values can be null, but cannot contain nulls. Arrays, maps and structs can be null and can contains nulls. Non-null array may contain one or more elements that are null or contain nulls themselves. Non-null maps may contain one more entry with key or value that's null or contains null. Non-null struct may contain a field that's null or contains null. This functionality is need to implement IN predicate for complex types: facebookincubator#6513 Pull Request resolved: facebookincubator#6515 Reviewed By: pedroerp Differential Revision: D49155796 Pulled By: mbasmanova fbshipit-source-id: b935744575bc67efad746fb1161673aa430606c6
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
…ator#6513) Summary: In Presto, x IN (a, b, c) evaluated on complex types returns NULL if x doesn't match a, b, c, but contains null or any of a, b, c contains null. Depends on facebookincubator#6515 Pull Request resolved: facebookincubator#6513 Reviewed By: pedroerp Differential Revision: D49155902 Pulled By: mbasmanova fbshipit-source-id: 5149122a9e888d2831d9462167fd3ac33ce04db8
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
Summary: BaseVector::containsNullAt(idx) returns true if value at the specified index is null or contains null. Primitive type values can be null, but cannot contain nulls. Arrays, maps and structs can be null and can contains nulls. Non-null array may contain one or more elements that are null or contain nulls themselves. Non-null maps may contain one more entry with key or value that's null or contains null. Non-null struct may contain a field that's null or contains null. This functionality is need to implement IN predicate for complex types: facebookincubator#6513 Pull Request resolved: facebookincubator#6515 Reviewed By: pedroerp Differential Revision: D49155796 Pulled By: mbasmanova fbshipit-source-id: b935744575bc67efad746fb1161673aa430606c6
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
…ator#6513) Summary: In Presto, x IN (a, b, c) evaluated on complex types returns NULL if x doesn't match a, b, c, but contains null or any of a, b, c contains null. Depends on facebookincubator#6515 Pull Request resolved: facebookincubator#6513 Reviewed By: pedroerp Differential Revision: D49155902 Pulled By: mbasmanova fbshipit-source-id: 5149122a9e888d2831d9462167fd3ac33ce04db8
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
Summary: BaseVector::containsNullAt(idx) returns true if value at the specified index is null or contains null. Primitive type values can be null, but cannot contain nulls. Arrays, maps and structs can be null and can contains nulls. Non-null array may contain one or more elements that are null or contain nulls themselves. Non-null maps may contain one more entry with key or value that's null or contains null. Non-null struct may contain a field that's null or contains null. This functionality is need to implement IN predicate for complex types: facebookincubator#6513 Pull Request resolved: facebookincubator#6515 Reviewed By: pedroerp Differential Revision: D49155796 Pulled By: mbasmanova fbshipit-source-id: b935744575bc67efad746fb1161673aa430606c6
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
…ator#6513) Summary: In Presto, x IN (a, b, c) evaluated on complex types returns NULL if x doesn't match a, b, c, but contains null or any of a, b, c contains null. Depends on facebookincubator#6515 Pull Request resolved: facebookincubator#6513 Reviewed By: pedroerp Differential Revision: D49155902 Pulled By: mbasmanova fbshipit-source-id: 5149122a9e888d2831d9462167fd3ac33ce04db8
ericyuliu
pushed a commit
to ericyuliu/velox
that referenced
this pull request
Oct 12, 2023
Summary: BaseVector::containsNullAt(idx) returns true if value at the specified index is null or contains null. Primitive type values can be null, but cannot contain nulls. Arrays, maps and structs can be null and can contains nulls. Non-null array may contain one or more elements that are null or contain nulls themselves. Non-null maps may contain one more entry with key or value that's null or contains null. Non-null struct may contain a field that's null or contains null. This functionality is need to implement IN predicate for complex types: facebookincubator#6513 Pull Request resolved: facebookincubator#6515 Reviewed By: pedroerp Differential Revision: D49155796 Pulled By: mbasmanova fbshipit-source-id: b935744575bc67efad746fb1161673aa430606c6
ericyuliu
pushed a commit
to ericyuliu/velox
that referenced
this pull request
Oct 12, 2023
…ator#6513) Summary: In Presto, x IN (a, b, c) evaluated on complex types returns NULL if x doesn't match a, b, c, but contains null or any of a, b, c contains null. Depends on facebookincubator#6515 Pull Request resolved: facebookincubator#6513 Reviewed By: pedroerp Differential Revision: D49155902 Pulled By: mbasmanova fbshipit-source-id: 5149122a9e888d2831d9462167fd3ac33ce04db8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseVector::containsNullAt(idx) returns true if value at the specified index
is null or contains null.
Primitive type values can be null, but cannot contain nulls. Arrays, maps
and structs can be null and can contains nulls. Non-null array may contain
one or more elements that are null or contain nulls themselves. Non-null
maps may contain one more entry with key or value that's null or contains
null. Non-null struct may contain a field that's null or contains null.
This functionality is need to implement IN predicate for complex types: #6513