Support UNKNOWN type in arbitrary aggregation #6557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49241110 |
kevinwilfong
added a commit
to kevinwilfong/velox
that referenced
this pull request
Sep 13, 2023
Summary: This change adds support for the UNKNOWN type in arbitrary aggregation. It mostly comes up when a query includes arbitrary(NULL) as a means of getting a NULL from an aggregate without needing to group by it. It's fairly trivial since NonNumericArbitrary supports it directly. Differential Revision: D49241110
kevinwilfong
force-pushed
the
export-D49241110
branch
from
2ca00e0
to
a492a3f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49241110 |
Summary: This change adds support for the UNKNOWN type in arbitrary aggregation. It mostly comes up when a query includes arbitrary(NULL) as a means of getting a NULL from an aggregate without needing to group by it. It's fairly trivial since NonNumericArbitrary supports it directly. Reviewed By: mbasmanova Differential Revision: D49241110
kevinwilfong
added a commit
to kevinwilfong/velox
that referenced
this pull request
Sep 14, 2023
Summary: This change adds support for the UNKNOWN type in arbitrary aggregation. It mostly comes up when a query includes arbitrary(NULL) as a means of getting a NULL from an aggregate without needing to group by it. It's fairly trivial since NonNumericArbitrary supports it directly. Reviewed By: mbasmanova Differential Revision: D49241110
kevinwilfong
force-pushed
the
export-D49241110
branch
from
a492a3f
to
ae3c213
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49241110 |
kevinwilfong
force-pushed
the
export-D49241110
branch
from
ae3c213
to
fd1dd09
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49241110 |
|
This pull request has been merged in 926a49f. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
Summary: Pull Request resolved: facebookincubator#6557 This change adds support for the UNKNOWN type in arbitrary aggregation. It mostly comes up when a query includes arbitrary(NULL) as a means of getting a NULL from an aggregate without needing to group by it. It's fairly trivial since NonNumericArbitrary supports it directly. Reviewed By: mbasmanova Differential Revision: D49241110 fbshipit-source-id: f90b832f46ac121b67bf7d8bdf40a1bbaa9f70da
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
Summary: Pull Request resolved: facebookincubator#6557 This change adds support for the UNKNOWN type in arbitrary aggregation. It mostly comes up when a query includes arbitrary(NULL) as a means of getting a NULL from an aggregate without needing to group by it. It's fairly trivial since NonNumericArbitrary supports it directly. Reviewed By: mbasmanova Differential Revision: D49241110 fbshipit-source-id: f90b832f46ac121b67bf7d8bdf40a1bbaa9f70da
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
Summary: Pull Request resolved: facebookincubator#6557 This change adds support for the UNKNOWN type in arbitrary aggregation. It mostly comes up when a query includes arbitrary(NULL) as a means of getting a NULL from an aggregate without needing to group by it. It's fairly trivial since NonNumericArbitrary supports it directly. Reviewed By: mbasmanova Differential Revision: D49241110 fbshipit-source-id: f90b832f46ac121b67bf7d8bdf40a1bbaa9f70da
ericyuliu
pushed a commit
to ericyuliu/velox
that referenced
this pull request
Oct 12, 2023
Summary: Pull Request resolved: facebookincubator#6557 This change adds support for the UNKNOWN type in arbitrary aggregation. It mostly comes up when a query includes arbitrary(NULL) as a means of getting a NULL from an aggregate without needing to group by it. It's fairly trivial since NonNumericArbitrary supports it directly. Reviewed By: mbasmanova Differential Revision: D49241110 fbshipit-source-id: f90b832f46ac121b67bf7d8bdf40a1bbaa9f70da
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change adds support for the UNKNOWN type in arbitrary aggregation, it's fairly trivial since
NonNumericArbitrary supports it directly.
Differential Revision: D49241110