Add bitwise_xor_agg Presto aggregate function #6705
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
xumingming
force-pushed
the
bitwise-xor-agg
branch
from
efe3726
to
7ebd5ba
Compare
|
@mbasmanova can you help review this simple PR? |
mbasmanova
approved these changes
Sep 27, 2023
|
|
||
| Returns the bitwise XOR of all input values in 2's complement representation. | ||
|
|
||
| Supported types are TINYINT, SMALLINT, INTEGER and BIGINT. |
There was a problem hiding this comment.
I noticed recently that Presto only supports BIGINT. Is this the case?
There was a problem hiding this comment.
Yes, I commented this fact in another PR.
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@mbasmanova merged this pull request in d1c7bd9. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
ericyuliu
pushed a commit
to ericyuliu/velox
that referenced
this pull request
Oct 12, 2023
Summary: Fixes facebookincubator#6690 Fuzzer results: ``` ./velox/exec/tests/velox_aggregation_fuzzer_test --logtostderr --only "bitwise_xor_agg" --duration_sec 3600 I20230924 20:15:29.420713 3407272 AggregationFuzzer.cpp:780] ==============================> Done with iteration 5310 I20230924 20:15:29.420739 3407272 AggregationFuzzer.cpp:1503] Total functions tested: 1 I20230924 20:15:29.420745 3407272 AggregationFuzzer.cpp:1504] Total masked aggregations: 812 (15.29%) I20230924 20:15:29.421257 3407272 AggregationFuzzer.cpp:1506] Total global aggregations: 410 (7.72%) I20230924 20:15:29.421263 3407272 AggregationFuzzer.cpp:1508] Total group-by aggregations: 3880 (73.06%) I20230924 20:15:29.421272 3407272 AggregationFuzzer.cpp:1510] Total distinct aggregations: 544 (10.24%) I20230924 20:15:29.421276 3407272 AggregationFuzzer.cpp:1512] Total window expressions: 477 (8.98%) I20230924 20:15:29.421281 3407272 AggregationFuzzer.cpp:1514] Total aggregations verified against DuckDB: 487 (9.17%) I20230924 20:15:29.421286 3407272 AggregationFuzzer.cpp:1516] Total failed aggregations: 0 (0.00%) [==========] Running 0 tests from 0 test suites. [==========] 0 tests from 0 test suites ran. (0 ms total) [ PASSED ] 0 tests. ``` Pull Request resolved: facebookincubator#6705 Reviewed By: xiaoxmeng Differential Revision: D49674610 Pulled By: mbasmanova fbshipit-source-id: d7aa2b002a5399a1c96ac1c36f19f243e59ad951
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6690
Fuzzer results: