Add support for VARBINARY inputs to length Presto function #6795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49731494 |
mbasmanova
reviewed
Sep 28, 2023
There was a problem hiding this comment.
@laithsakka Thank you for adding this capability. Looks great % some comments and
- Please, update PR title to "Add support for VARBINARY inputs to length Presto function" (notice capatalization)
- Please, update documentation
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Sep 28, 2023
Summary: title Differential Revision: D49731494
laithsakka
force-pushed
the
export-D49731494
branch
from
78e4703
to
67289e1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49731494 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Sep 28, 2023
Summary: title Differential Revision: D49731494
laithsakka
force-pushed
the
export-D49731494
branch
from
67289e1
to
042d1d3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49731494 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Sep 28, 2023
…cubator#6795) Summary: title Differential Revision: D49731494
laithsakka
force-pushed
the
export-D49731494
branch
from
042d1d3
to
8c05e7d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49731494 |
mbasmanova
reviewed
Sep 28, 2023
| @@ -2,6 +2,10 @@ | |||
| Binary Functions | |||
| ================ | |||
|
|
|||
| .. function:: length(binary) -> bigint | |||
There was a problem hiding this comment.
Please, keep functions in alphabetical order.
mbasmanova
changed the title
…cubator#6795) Summary: title Differential Revision: D49731494
laithsakka
force-pushed
the
export-D49731494
branch
from
8c05e7d
to
3eb87a2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49731494 |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
|
This pull request has been merged in 3cdb250. |
ericyuliu
pushed a commit
to ericyuliu/velox
that referenced
this pull request
Oct 12, 2023
…cubator#6795) Summary: Pull Request resolved: facebookincubator#6795 title Reviewed By: mbasmanova Differential Revision: D49731494 fbshipit-source-id: ea80338710609442d9240db5c30fd03c2c44c157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: title
Differential Revision: D49731494