HugeInt support in TypeSignature conversion (#6537) #6799
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49212995 |
kagamiori
reviewed
Sep 28, 2023
| .returnType("hugeint") | ||
| .argumentType("hugeint") | ||
| .build(); | ||
| testSignatureBinder(signature, {HUGEINT()}, HUGEINT()); |
There was a problem hiding this comment.
Thank you for adding this test! Could you also test that if a function signature is T -> T, whether {HUGEINT()} argument type can be correctly resolved?
|
This pull request was exported from Phabricator. Differential Revision: D49212995 |
Summary: This came up while interpreting Velox function signatures. Eg UDFs using HugeInt. Reviewed By: darrenfu, pedroerp Differential Revision: D49212995
|
This pull request was exported from Phabricator. Differential Revision: D49212995 |
|
Recreate new PR for linux build issues. |
|
This pull request was exported from Phabricator. Differential Revision: D49212995 |
2 similar comments
|
This pull request was exported from Phabricator. Differential Revision: D49212995 |
|
This pull request was exported from Phabricator. Differential Revision: D49212995 |
panditsurabhi
pushed a commit
to panditsurabhi/velox
that referenced
this pull request
Sep 28, 2023
Summary: Pull Request resolved: facebookincubator#6799 This came up while interpreting Velox function signatures. Eg UDFs using HugeInt. Reviewed By: darrenfu, pedroerp Differential Revision: D49212995 fbshipit-source-id: 7362e1c22af33ddb355757545cee2dbf5da4f25a
panditsurabhi
pushed a commit
to panditsurabhi/velox
that referenced
this pull request
Sep 28, 2023
Summary: This came up while interpreting Velox function signatures. Eg UDFs using HugeInt. Reviewed By: darrenfu, pedroerp Differential Revision: D49212995
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
Summary: Pull Request resolved: #6799 This came up while interpreting Velox function signatures. Eg UDFs using HugeInt. Reviewed By: darrenfu, pedroerp Differential Revision: D49212995 fbshipit-source-id: 5f39548134ab13d0ca6df11ff0895245c7f4165c
ericyuliu
pushed a commit
to ericyuliu/velox
that referenced
this pull request
Oct 12, 2023
Summary: Pull Request resolved: facebookincubator#6799 This came up while interpreting Velox function signatures. Eg UDFs using HugeInt. Reviewed By: darrenfu, pedroerp Differential Revision: D49212995 fbshipit-source-id: 5f39548134ab13d0ca6df11ff0895245c7f4165c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This came up while interpreting Velox function signatures. Eg UDFs using HugeInt.
Reviewed By: darrenfu, pedroerp
Differential Revision: D49212995