Fix set_union Presto aggregate #6800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
mbasmanova
changed the title
facebook-github-bot
added
the
CLA Signed
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mbasmanova
force-pushed
the
fix-set-union
branch
from
f2d4794
to
e3c5580
Compare
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xiaoxmeng
approved these changes
Sep 28, 2023
|
@mbasmanova merged this pull request in 85578c5. |
ericyuliu
pushed a commit
to ericyuliu/velox
that referenced
this pull request
Oct 12, 2023
Summary: set_union semantics in Presto are non-intuitive. When all inputs are null, set_union returns an empty array, not a null. Fixes facebookincubator#6720 Pull Request resolved: facebookincubator#6800 Reviewed By: xiaoxmeng Differential Revision: D49736358 Pulled By: mbasmanova fbshipit-source-id: a47b5fff7199f899b4cbe7e950d46fd23c89458f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_union semantics in Presto are non-intuitive. When all inputs are null,
set_union returns an empty array, not a null.
Fixes #6720