Fix window aggregate result for empty frames #6872
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
aditi-pandit
reviewed
Oct 4, 2023
velox/functions/prestosql/window/tests/SimpleAggregatesTest.cpp
Outdated
Show resolved
Hide resolved
pramodsatya
force-pushed
the
window_agg
branch
from
e5db75d
to
cd013d5
Compare
aditi-pandit
reviewed
Oct 5, 2023
velox/functions/prestosql/window/tests/SimpleAggregatesTest.cpp
Outdated
Show resolved
Hide resolved
pramodsatya
force-pushed
the
window_agg
branch
from
020a26e
to
15c728e
Compare
pramodsatya
force-pushed
the
window_agg
branch
3 times, most recently
from
70d3458
to
7c6225a
Compare
pramodsatya
force-pushed
the
window_agg
branch
from
7c6225a
to
0a06d2c
Compare
velox/functions/prestosql/window/tests/SimpleAggregatesTest.cpp
Outdated
Show resolved
Hide resolved
pramodsatya
force-pushed
the
window_agg
branch
2 times, most recently
from
418329f
to
b48d06f
Compare
aditi-pandit
approved these changes
Oct 18, 2023
mbasmanova
reviewed
Oct 19, 2023
mbasmanova
approved these changes
Oct 19, 2023
velox/functions/prestosql/window/tests/SimpleAggregatesTest.cpp
Outdated
Show resolved
Hide resolved
pramodsatya
force-pushed
the
window_agg
branch
from
b48d06f
to
99b9e78
Compare
pramodsatya
commented
Oct 19, 2023
There was a problem hiding this comment.
Thanks for the feedback @mbasmanova, addressed the comments.
velox/functions/prestosql/window/tests/SimpleAggregatesTest.cpp
Outdated
Show resolved
Hide resolved
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pramodsatya Got a lint warning: 
|
pramodsatya
force-pushed
the
window_agg
branch
from
99b9e78
to
dccc69b
Compare
Fixed, thanks for sharing @mbasmanova |
mbasmanova
reviewed
Oct 19, 2023
velox/functions/prestosql/window/tests/SimpleAggregatesTest.cpp
Outdated
Show resolved
Hide resolved
pramodsatya
force-pushed
the
window_agg
branch
from
dccc69b
to
8879104
Compare
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
|
@mbasmanova merged this pull request in 560b027. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presto returns the default value of the aggregate for rows with empty frames. Velox like DuckDB always returned nulls. Fix Velox behavior to be consistent with Presto.
The default value of aggregates is usually null, but there are aggregates like count which return 0.
Resolves #6416